8000 removed deprecated Twig features by fabpot · Pull Request #13409 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

removed deprecated Twig features #13409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 16, 2015
Merged

removed deprecated Twig features #13409

merged 1 commit into from
Jan 16, 2015

Conversation

fabpot
Copy link
Member
@fabpot fabpot commented Jan 14, 2015
Q A
Bug fix? no
New feature? no
BC breaks? yes
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

Tobion
Tobion reviewed Jan 14, 2015
View reviewed changes
src/Symfony/Bundle/TwigBundle/Resources/config/schema/twig-1.0.xsd
@@ -9,8 +9,6 @@

<xsd:complexType name="config">
<xsd:sequence>
<!-- @deprecated since version 2.6, to be removed in 3.0 -->
<xsd:element name="form" type="form" minOccurs="0" maxOccurs="1" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you can also remove the complexType name="form"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, fixed

@fabpot fabpot force-pushed the twig-deprecated-removal branch 2 times, most recently from a163635 to 9994c02 Compare January 16, 2015 07:22
Tobion
Tobion reviewed Jan 16, 2015
View reviewed changes
src/Symfony/Bridge/Twig/AppVariable.php
@@ -25,20 +24,11 @@
*/
class AppVariable
{
private $security;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this property is still referenced in getUser

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@Tobion
Copy link
Contributor
Tobion commented Jan 16, 2015

apart from comment above, 👍

@fabpot fabpot force-pushed the twig-deprecated-removal branch from 9994c02 to 2afd614 Compare January 16, 2015 07:41
@fabpot fabpot merged commit 2afd614 into symfony:master Jan 16, 2015
fabpot added a commit that referenced this pull request Jan 16, 2015
@fabpot
feature #13409 removed deprecated Twig features (fabpot)
7b6f6d7 
This PR was merged into the 3.0-dev branch.

Discussion
----------

removed deprecated Twig features

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Commits
-------

2afd614 removed deprecated Twig features
@fabpot fabpot deleted the twig-deprecated-removal branch February 12, 2015 09:34
@fabpot fabpot mentioned this pull request Nov 16, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
TwigBundle
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fabpot @Tobion
0