8000 [TwigBundle] use the new Twig autoescaping strategy by fabpot · Pull Request #13401 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[TwigBundle] use the new Twig autoescaping strategy #13401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 14, 2015
Merged

[TwigBundle] use the new Twig autoescaping strategy #13401

merged 1 commit into from
Jan 14, 2015

Conversation

fabpot
Copy link
Member
@fabpot fabpot commented Jan 13, 2015
Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

fabpot
fabpot reviewed Jan 13, 2015
View reviewed changes
src/Symfony/Bridge/Twig/composer.json
@@ -18,7 +18,7 @@
"require": {
"php": ">=5.3.9",
"symfony/security-csrf": "~2.6|~3.0.0",
"twig/twig": "~1.13,>=1.13.1"
"twig/twig": "~1.17"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to release Twig 1.17 first to make the tests pass.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest waiting until Twig 1.17 is released before merging this then

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and the root composer.json also needs to be updated with the new Twig constraint

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@fabpot fabpot force-pushed the twig-escaping branch 2 times, most recently from dbd689d to 8dbe832 Compare January 13, 2015 17:47
@fabpot fabpot merged commit 55c4b41 into symfony:2.7 Jan 14, 2015
fabpot added a commit that referenced this pull request Jan 14, 2015
@fabpot
feature #13401 [TwigBundle] use the new Twig autoescaping strategy (f…
8d12652 
…abpot)

This PR was merged into the 2.7 branch.

Discussion
----------

[TwigBundle] use the new Twig autoescaping strategy

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Commits
-------

55c4b41 [TwigBundle] use the new Twig autoescaping strategy
@fabpot fabpot deleted the twig-escaping branch February 12, 2015 09:34
@mtijink mtijink mentioned this pull request Jun 1, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fabpot @stof @peterrehm
0