Profiler log design #134
Merged
Profiler log design #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he number of errors
|
This has just been rebased to take the new design into account. |
|
For me, the number of log lines is irrelevant. I'm only interested in knowing whether there is some errors or not. |
|
Having a count of "0" might be misleading when there are no error (made me think there were no log at all). |
|
Right, if there is 0 errors, then, we should remove the count altogether. Good compromise indeed. |
…display only the number of errors when required
|
here you go |
jderusse
pushed a commit
to jderusse/symfony
that referenced
this pull request
Mar 30, 2020
Add joomla/session RCE vulnerability
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display the total number of log entries & highlight error count if any.