[2.7] Fix deprecations on TwigBundle and FrameworkBundle semantic configurations #13349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | ~ |
| License | MIT |
| Doc PR | ~ |
7f8f81e to
78f30c5
Compare
| @@ -44,6 +44,12 @@ class FrameworkExtension extends Extension | |||
| */ | |||
| public function load(array $configs, ContainerBuilder $container) | |||
| { | |||
| // Check deprecation before the config is processed to ensure | |||
| // the setting has been explicitly defined in a configuration file. | |||
| if (isset($configs['csrf_protection']['field_name'])) { | |||
There was a problem hiding this comment.
this will always be false, given that $configs is the array of configs coming from the different files.
If you want to do this before the processing, put it in the beforeNormalization of the node in the Configuration class
There was a problem hiding this comment.
Yes you're right. I forgot $configs is a multidimensional array.
bb318b5 to
ecb240a
Compare
|
Squashed! Should be green in a few minutes. |
|
@hhamon Almost there... but not quite: https://travis-ci.org/symfony/symfony/jobs/46471343#L1742 |
…les to not use deprecated config keys anymore.
ecb240a to
8d60396
Compare
|
@fabpot looks good except on 5.3 due to the Process component. Can you please run |
|
Thank you @hhamon. |
fabpot
added a commit
that referenced
this pull request
Jan 9, 2015
… semantic configurations (hhamon) This PR was merged into the 2.7 branch. Discussion ---------- [2.7] Fix deprecations on TwigBundle and FrameworkBundle semantic configurations | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ~ | License | MIT | Doc PR | ~ Commits ------- 8d60396 [FrameworkBundle|TwigBundle] update functional tests configuration files to not use deprecated config keys anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.