[OptionsResolver] added test for allowed values and types that default to null #13331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The case experienced in #12809 is not specifically about you will get the same BC break in 2.6 for any not allowed default value because of the bugfix (which was precisely about default values not being validated) |
|
True, then it's even more important not to revert that. The tests I added here show exactly that both invalid values with setDefault() as well as with resolve() throw an exception. |
|
but this is already tested (with the test using |
|
Yes but there has been no test where the invalid value is passed to |
|
ping |
|
@stof you ok with the PR? |
|
👍 |
|
Thank you @Tobion. |
fabpot
added a commit
that referenced
this pull request
Jan 26, 2015
…s that default to null (Tobion) This PR was merged into the 2.6 branch. Discussion ---------- [OptionsResolver] added test for allowed values and types that default to null | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | no | Fixed tickets | - | License | MIT | Doc PR | - Added test to keep logic as experienced in #12809 Commits ------- 0b42cad [OptionsResolver] added test for allowed values and types that default to null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added test to keep logic as experienced in #12809