[Console] fixed 10531 #13309
Merged
[Console] fixed 10531 #13309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -469,10 +469,10 @@ public function getNamespaces() | |||
| { | |||
| $namespaces = array(); | |||
| foreach ($this->commands as $command) { | |||
| $namespaces[] = $this->extractNamespace($command->getName()); | |||
| $namespaces = array_merge($namespaces, $this->extractAllNamespaces($command->getName())); | |||
There was a problem hiding this comment.
array_merge is not necessary here
$namespaces = $this->extractAllNamespaces($command->getName());|
👍 nice work @nacmartin ... and thanks for the patience going through the commit review process! |
|
OK, 👍 |
|
Thank you @nacmartin. |
fabpot
added a commit
that referenced
this pull request
Jan 25, 2015
This PR was merged into the 2.3 branch. Discussion ---------- [Console] fixed 10531 | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #10531 | License | MIT | Doc PR | - This is a fix for #10531. It works by extracting all the parent namespaces of a command. Commits ------- e6afff4 [Console] fixed #10531
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #10531. It works by extracting all the parent namespaces of a command.