8000 [Security] Don't destroy the session on buggy php releases. by derrabus · Pull Request #13286 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Security] Don't destroy the session on buggy php releases. #13286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[Security] Don't destroy the session on buggy php releases. #13286

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb00e2c
Don't destroy the session on buggy php releases.
derrabus Jan 6, 2015
83aaaa9
php -> PHP
derrabus Jan 7, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
php -> PHP
  • Loading branch information
@derrabus
derrabus committed Jan 7, 2015
commit 83aaaa98c080610c9a5b4f29ad7f22dfef3ec3e6
4 changes: 2 additions & 2 deletions src/Symfony/Component/Security/Tests/Http/Session/SessionAuthenticationStrategyTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ public function testUnsupportedStrategy()
public function testSessionIsMigrated()
{
if (PHP_VERSION_ID >= 50400 && PHP_VERSION_ID < 50411) {
$this->markTestSkipped('We must not destroy the old session on php 5.4.0 - 5.4.10.');
$this->markTestSkipped('We cannot destroy the old session on PHP 5.4.0 - 5.4.10.');
}

$session = $this->getMock('Symfony\Component\HttpFoundation\Session\SessionInterface');
Expand All @@ -53,7 +53,7 @@ public function testSessionIsMigrated()
public function testSessionIsMigratedWithPhp54Workaround()
{
if (PHP_VERSION_ID < 50400 || PHP_VERSION_ID >= 50411) {
$this->markTestSkipped('This php version is not affected.');
$this->markTestSkipped('This PHP version is not affected.');
}

$session = $this->getMock('Symfony\Component\HttpFoundation\Session\SessionInterface');
Expand Down
0