8000 [Yaml] Improve YAML boolean escaping by petert82 · Pull Request #13262 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Yaml] Improve YAML boolean escaping #13262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 16, 2015
Merged

[Yaml] Improve YAML boolean escaping #13262

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3760e67
[Yaml] Improve YAML boolean escaping
petert82 Jan 5, 2015
81a8090
Remove duplicate 'require'
larowlan Jan 6, 2015
1e0633e
Merge pull request #1 from larowlan/patch-1
petert82 Jan 6, 2015
a0ec0fe
Add comment as requested
larowlan Jan 6, 2015
afe827a
Merge pull request #2 from larowlan/patch-2
petert82 Jan 6, 2015
8fa056b
Inline private 'is quoting required' methods in Escaper
Jan 16, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Symfony/Component/Yaml/Escaper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,8 @@ private static function containsCharRequiresSingleQuoting($value)
*/
private static function isValueRequiresSingleQuoting($value)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesValueRequireSingleQuoting?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I'm wondering if we really need those 2 private methods. What about inlining them with the right comments instead? Especially as they can be called quite a lot.

{
// Note that whilst 'y' and 'n' are not supported as valid Booleans,
// they are escaped here for interoperability.
return in_array(strtolower($value), array('null', '~', 'true', 'false', 'y', 'n', 'yes', 'no', 'on', 'off'));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to myself and others: even if we do not support 'y', 'n', ... as valid Booleans, it does not hurt to escape them here for interoperability.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest adding it as a comment to avoid removing it by mistake in the future

}
}
0