-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[2.7] Allow 3.0 requirements #13135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.7] Allow 3.0 requirements #13135
Conversation
Sibling PR on 3.0: #12522 |
I don't agree.
What? Then we don't need to releae 3.0 at all and just call it 2.8.
This assumes we have full test coverage which is obviously not true. So why test 2.7 with 3.0 in the first place? |
Of course we do: otherwise we won't be able to remove deprecated interfaces.
It just account for what we have. It's better than being blind. |
👍 |
Why |
@Tobion I chose |
Thank you @nicolas-grekas. |
This PR was merged into the 2.7 branch. Discussion ---------- [2.7] Allow 3.0 requirements | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | lets see | Fixed tickets | - | License | MIT | Doc PR | - 2.7 is going to provide almost the same interfaces as 3.0 but also a BC layer for previous releases. This means that 2.7 is going to be mostly compatible with 3.0. Lets continuously test this assumption and see when and were we break compat with 2.7 (and try to avoid it as much as possible to smoothen the transition to 3.0). Commits ------- b369bb6 [2.7] Allow 3.0 requirements
"symfony/translation": "~2.0,>=2.0.5", | ||
"symfony/stopwatch": "~2.2|~3.0.0", | ||
"symfony/dependency-injection": "~2.2|~3.0.0", | ||
"symfony/form": "~2.3,>=2.3.8|~3.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would not do it for the Form component, because we already know that we will have hard BC breaks in it (changing the typehint to use OptionsResolver rather than the deprecated OptionsResolverInterface)
This PR was merged into the 2.7 branch. Discussion ---------- [2.7] Allow 3.0 requirements | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | lets see | Fixed tickets | - | License | MIT | Doc PR | - 2.7 is going to provide almost the same interfaces as 3.0 but also a BC layer for previous releases. This means that 2.7 is going to be mostly compatible with 3.0. Lets continuously test this assumption and see when and were we break compat with 2.7 (and try to avoid it as much as possible to smoothen the transition to 3.0). Commits ------- b369bb6 [2.7] Allow 3.0 requirements
2.7 is going to provide almost the same interfaces as 3.0 but also a BC layer for previous releases.
This means that 2.7 is going to be mostly compatible with 3.0.
Lets continuously test this assumption and see when and were we break compat with 2.7 (and try to avoid it as much as possible to smoothen the transition to 3.0).