8000 [2.7] Allow 3.0 requirements by nicolas-grekas · Pull Request #13135 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[2.7] Allow 3.0 requirements #13135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 30, 2014
Merged

[2.7] Allow 3.0 requirements #13135

merged 1 commit into from
Dec 30, 2014

Conversation

nicolas-grekas
Copy link
Member
Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? lets see
Fixed tickets -
License MIT
Doc PR -

2.7 is going to provide almost the same interfaces as 3.0 but also a BC layer for previous releases.
This means that 2.7 is going to be mostly compatible with 3.0.
Lets continuously test this assumption and see when and were we break compat with 2.7 (and try to avoid it as much as possible to smoothen the transition to 3.0).

@nicolas-grekas
Copy link
Member Author

Sibling PR on 3.0: #12522

@Tobion
Copy link
Contributor
Tobion commented Dec 27, 2014

I don't agree.

and try to avoid it as much as possible to smoothen the transition to 3.0

What? Then we don't need to releae 3.0 at all and just call it 2.8.

2.7 is going to be mostly compatible with 3.0. Lets continuously test this assumption and see when and were we break compat with 2.7

This assumes we have full test coverage which is obviously not true. So why test 2.7 with 3.0 in the first place?

@nicolas-grekas
Copy link
Member Author

What? Then we don't need to releae 3.0 at all and just call it 2.8.

Of course we do: otherwise we won't be able to remove deprecated interfaces.

This assumes we have full test coverage which is obviously not true. So why test 2.7 with 3.0 in the first place?

It just account for what we have. It's better than being blind.

@fabpot
Copy link
Member
fabpot commented Dec 29, 2014

👍

@Tobion
Copy link
Contributor
Tobion commented Dec 29, 2014

Why ~3.0.0 and not ~3.0? If 3.0 is compatible with 2.7, then 3.1 as well according to our semantic versioning.

@nicolas-grekas
Copy link
Member Author

@Tobion I chose ~3.0.0 to open the transition to 3.0, but shorten 2.7 lifetime.

@fabpot
Copy link
Member
fabpot commented Dec 30, 2014

Thank you @nicolas-grekas.

@fabpot fabpot merged commit b369bb6 into symfony:2.7 Dec 30, 2014
fabpot added a commit that referenced this pull request Dec 30, 2014
This PR was merged into the 2.7 branch.

Discussion
----------

[2.7] Allow 3.0 requirements

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | lets see
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

2.7 is going to provide almost the same interfaces as 3.0 but also a BC layer for previous releases.
This means that 2.7 is going to be mostly compatible with 3.0.
Lets continuously test this assumption and see when and were we break compat with 2.7 (and try to avoid it as much as possible to smoothen the transition to 3.0).

Commits
-------

b369bb6 [2.7] Allow 3.0 requirements
@nicolas-grekas nicolas-grekas deleted the allow-30 branch December 30, 2014 08:57
"symfony/translation": "~2.0,>=2.0.5",
"symfony/stopwatch": "~2.2|~3.0.0",
"symfony/dependency-injection": "~2.2|~3.0.0",
"symfony/form": "~2.3,>=2.3.8|~3.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not do it for the Form component, because we already know that we will have hard BC breaks in it (changing the typehint to use OptionsResolver rather than the deprecated OptionsResolverInterface)

jderusse pushed a commit to jderusse/symfony that referenced this pull request Dec 15, 2020
This PR was merged into the 2.7 branch.

Discussion
----------

[2.7] Allow 3.0 requirements

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | lets see
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

2.7 is going to provide almost the same interfaces as 3.0 but also a BC layer for previous releases.
This means that 2.7 is going to be mostly compatible with 3.0.
Lets continuously test this assumption and see when and were we break compat with 2.7 (and try to avoid it as much as possible to smoothen the transition to 3.0).

Commits
-------

b369bb6 [2.7] Allow 3.0 requirements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0