8000 [Yaml] Removed the ability to parse a file in Yaml::parse() by saro0h · Pull Request #13129 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content
8000

[Yaml] Removed the ability to parse a file in Yaml::parse() #13129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 29, 2014

Conversation

saro0h
Copy link
Contributor
@saro0h saro0h commented Dec 26, 2014
Q A
Bug fix? no
New feature? no
BC breaks? yes
Deprecations? no
Tests pass? yes
Fixed tickets ~
License MIT
Doc PR ~

$file = $input;
$input = file_get_contents($file);
}

$yaml = new Parser();

try {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return (new Parser())->parse ... should work?
no need for the try / catch block.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay!

@fabpot
Copy link
Member
fabpot commented Dec 29, 2014

Thank you @saro0h.

@fabpot fabpot merged commit e1c19f8 into symfony:master Dec 29, 2014
fabpot added a commit that referenced this pull request Dec 29, 2014
…rse() (saro0h)

This PR was merged into the 3.0-dev branch.

Discussion
----------

[Yaml] Removed the ability to parse a file in Yaml::parse()

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | ~
| License       | MIT
| Doc PR        | ~

Commits
-------

e1c19f8 [Yaml] Removed the ability to parse a file in Yaml::parse()
wouterj added a commit to symfony/symfony-docs that referenced this pull request Jan 8, 2015
…rse() (xabbuh)

This PR was merged into the master branch.

Discussion
----------

[Components][Yaml] don't describe removed usage of Yaml::parse()

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no (but related to symfony/symfony#13129)
| Applies to    | 3.0+
| Fixed tickets |

Commits
-------

d33b78b don't describe removed usage of Yaml::parse()
@fabpot fabpot mentioned this pull request Nov 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0