8000 [Config] fix error handler restoration in test by nicolas-grekas · Pull Request #13075 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Config] fix error handler restoration in test #13075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 23, 2014
Merged

[Config] fix error handler restoration in test #13075

merged 1 commit into from
Dec 23, 2014

Conversation

nicolas-grekas
Copy link
Member
Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

@nicolas-grekas nicolas-grekas mentioned this pull request Dec 22, 2014
Merged
xabbuh
xabbuh reviewed Dec 22, 2014
View reviewed changes
src/Symfony/Component/Config/Tests/Util/XmlUtilsTest.php
}
} catch (\Exception $e) {
restore_error_handler();
error_reporting($errorReporting);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be easier to use this only once in a finally block?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, no sorry, it's not available in PHP 5.3.

@fabpot
Copy link
Member
fabpot commented Dec 23, 2014

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 266afeb into symfony:2.3 Dec 23, 2014
fabpot added a commit that referenced this pull request Dec 23, 2014
@fabpot
bug #13075 [Config] fix error handler restoration in test (nicolas-gr…
cad7f0e 
…ekas)

This PR was merged into the 2.3 branch.

Discussion
----------

[Config] fix error handler restoration in test

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

266afeb [Config] fix error handler restoration in test
@nicolas-grekas nicolas-grekas deleted the fix-test-xml branch December 24, 2014 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolas-grekas @fabpot @xabbuh
0