8000 [2.7] [Bridge] [Swiftmailer] adds deprecation notice on MessageDataCollector class. by hhamon · Pull Request #13056 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[2.7] [Bridge] [Swiftmailer] adds deprecation notice on MessageDataCollector class. #13056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 21, 2014
Merged

[2.7] [Bridge] [Swiftmailer] adds deprecation notice on MessageDataCollector class. #13056

merged 1 commit into from
Dec 21, 2014

Conversation

hhamon
Copy link
Contributor
@hhamon hhamon commented Dec 20, 2014
Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? yes
Tests pass? yes
Fixed tickets ~
License MIT
Doc PR ~

fabpot
fabpot reviewed Dec 21, 2014
View reviewed changes
src/Symfony/Bridge/Swiftmailer/DataCollector/MessageDataCollector.php
.' can be downloaded with Composer. See https://packagist.org/packages/symfony/swiftmailer-bundle.',
E_USER_DEPRECATED
);

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would move the trigger at the top of the class like done in other deprecated classes. Also, can you put the message on one line only? You can replace the class name with __CLASS__ to make it a bit shorter and instead of giving the URL to pakcagist, just mention the package name.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm on it ;)

@hhamon hhamon force-pushed the bridge-swiftmailer-deprecation-notice branch from a92fbf5 to c003bb1 Compare December 21, 2014 09:55
@hhamon
Copy link
Contributor Author
hhamon commented Dec 21, 2014

@fabpot changes have been applied.

@hhamon hhamon changed the title [Bridge] [Swiftmailer] adds deprecation notice on MessageDataCollector class. [2.7] [Bridge] [Swiftmailer] adds deprecation notice on MessageDataCollector class. Dec 21, 2014
@hhamon hhamon mentioned this pull request Dec 21, 2014
Merged
@fabpot
Copy link
Member
fabpot commented Dec 21, 2014

Thank you @hhamon.

@fabpot fabpot merged commit c003bb1 into symfony:2.7 Dec 21, 2014
fabpot added a commit that referenced this pull request Dec 21, 2014
@fabpot
minor #13056 [2.7] [Bridge] [Swiftmailer] adds deprecation notice on …
ff91d30 
…MessageDataCollector class. (hhamon)

This PR was merged into the 2.7 branch.

Discussion
----------

[2.7] [Bridge] [Swiftmailer] adds deprecation notice on MessageDataCollector class.

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | ~
| License       | MIT
| Doc PR        | ~

Commits
-------

c003bb1 [Bridge] [Swiftmailer] adds deprecation notice on MessageDataCollector class.
@hhamon hhamon deleted the bridge-swiftmailer-deprecation-notice branch December 21, 2014 10:45
Sign up for free to join this conversation on GitHub. Already have an accoun 590B t? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hhamon @fabpot
0