[Tests] Silenced all deprecations in tests for 2.3 #13033
Conversation
| /** | ||
| * @author Bernhard Schussek <bschussek@gmail.com> | ||
| */ | ||
| class UserPasswordValidatorTest extends AbstractConstraintValidatorTest |
There was a problem hiding this comment.
are you sure it does not run at all ?
There was a problem hiding this comment.
looks like this is a legacy file that missed a cleanup (test is never run if I'm not wrong?)
There was a problem hiding this comment.
As your can see here, it's not declared for the test suite : https://github.com/symfony/symfony/blob/2.3/phpunit.xml.dist#L34-L39
And not here too : https://github.com/symfony/symfony/blob/2.3/src/Symfony/Component/Security/phpunit.xml.dist#L20
There was a problem hiding this comment.
Indeed, this test is in the wrong path, and there is actually already a UserPasswordValidatorTest in Symfony\Component\Security\Tests\Core\Validator\Constraints.
There was a problem hiding this comment.
hmm indeed. The file is in the path where we moved tests in 2.4+ instead of being in the 2.3 location
|
👍 |
|
Thank you @saro0h. |
This PR was merged into the 2.3 branch. Discussion ---------- [Tests] Silenced all deprecations in tests for 2.3 | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ~ | License | MIT | Doc PR | ~ Also removed src/Symfony/Component/Security/Core/Tests/Validator/Constraints/UserPasswordValidatorTest.php as it was not running at all. Commits ------- ef4ae63 [Tests] Silenced all deprecations in tests for 2.3
This PR was merged into the 2.5 branch. Discussion ---------- [Security] Fixed tests | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ~ | License | MIT | Doc PR | ~ Fixes the tests failing (https://travis-ci.org/symfony/symfony/jobs/44732074#L896) This class have been removed in 2.3 (#13033) but is actually used since 2.4 (when the split of the Security componen 66A3 t has been made). Commits ------- 5aa3ef4 [Security] Fixed tests
Also removed src/Symfony/Component/Security/Core/Tests/Validator/Constraints/UserPasswordValidatorTest.php as it was not running at all.