[FrameworkBundle] fix cache:clear command #12999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -74,6 +74,7 @@ protected function execute(InputInterface $input, OutputInterface $output) | |||
| } else { | |||
| // the warmup cache dir name must have the same length than the real one | |||
| // to avoid the many problems in serialized resources files | |||
| $realCacheDir = realpath($realCacheDir); | |||
There was a problem hiding this comment.
If $realCacheDir does not exists, realpath file returns false
There was a problem hiding this comment.
The path exists because we checked it a few lines above with is_writable()
|
@nicolas-grekas great catch. It works great, but this way Here are my results: public function getCacheDir()
{
return '/tmp/sf/'.$this->getEnvironment();
}The partial diff of cache:warmup vs cache:clear 'kernel.root_dir' => '/home/egabor/dev/OSS/symfony-standard/app',
'kernel.environment' => 'dev',
'kernel.debug' => true,
- 'kernel.name' => 'app',
+ 'kernel.name' => 'ap_',
'kernel.cache_dir' => __DIR__,
'kernel.logs_dir' => '/home/egabor/dev/OSS/symfony-standard/app/logs',
'kernel.bundles' => array( public function getCacheDir()
{
return __DIR__.'/../../../../../../../tmp/sf/'.$this->getEnvironment();
}The partial diff of cache:warmup vs cache:clear 'kernel.root_dir' => '/home/egabor/dev/OSS/symfony-standard/app',
'kernel.environment' => 'dev',
'kernel.debug' => true,
- 'kernel.name' => 'app',
- 'kernel.cache_dir' => ('/home/egabor/dev/OSS/symfony-standard/app/../../../../../../..'.__DIR__),
+ 'kernel.name' => 'ap_',
+ 'kernel.cache_dir' => __DIR__,
'kernel.logs_dir' => '/home/egabor/dev/OSS/symfony-standard/app/logs',
'kernel.bundles' => array( |
bb5153c to
a14153a
Compare
|
I added a |
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Dec 17, 2014
This PR was merged into the 2.3 branch. Discussion ---------- [FrameworkBundle] fix cache:clear command | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #12893 | License | MIT | Doc PR | - Reading comment on #12893 stating that using absolute paths works around the pb, I tried using realpath(), and it works! Pending work on #12955 can be done quietly now. Commits ------- a14153a [FrameworkBundle] fix cache:clear command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reading comment on #12893 stating that using absolute paths works around the pb, I tried using realpath(),
and it works!
Pending work on #12955 can be done quietly now.