[Form] Add further timezone tests for date type #12843
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -373,6 +373,60 @@ public function testSetDataWithDifferentTimezoneDateTime() | |||
| $this->assertEquals('02.06.2010', $form->getViewData()); | |||
| } | |||
|
|
|||
| public function testSetDataWithDifferentPositiveUTCTimezoneDateTime() | |||
| { | |||
| date_default_timezone_set('Pacific/Tahiti'); | |||
There was a problem hiding this comment.
shouldn't you try to restore the original timezone after the test?
There was a problem hiding this comment.
The setup and tear down methods take care of that
|
Thank you @McSimp. |
fabpot
added a commit
that referenced
this pull request
Dec 29, 2014
This PR was merged into the 2.6 branch. Discussion ---------- [Form] Add further timezone tests for date type | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | no (failing tests added) | Fixed tickets | Adds tests for bug in #12808 | License | MIT | Doc PR | ~ #12404 removed the timezone options from DateType and TimeType, however the tests don't cover all cases and there was a bug introduced as per #12808. This PR adds tests for the expected behaviour but will not fix the bug. Unfortunately, it seems that the tests are being skipped in the form component on Travis (and have been for a year) - probably due to the ICU version being changed. Commits ------- f919793 [Form] Add further timezone tests for date type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests for the expected behaviour but will not fix the bug.
Unfortunately, it seems that the tests are being skipped in the form component on Travis (and have been for a year) - probably due to the ICU version being changed.