8000 Append to PR #12737 referring Ticket #12704 by rodrigobb · Pull Request #12759 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Append to PR #12737 referring Ticket #12704 #12759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Append to PR #12737 referring Ticket #12704 #12759

wants to merge 3 commits into from

Conversation

rodrigobb
Copy link
Contributor
Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #12704
License MIT
Doc PR -

@rodrigobb rodrigobb mentioned this pull request Nov 29, 2014
Closed
@xabbuh
Copy link
Member
xabbuh commented Nov 29, 2014

@rodrigobb Looks good.

@timglabisch
Copy link

@rodrigobb 👍 but you should rebase this to one commit

@fabpot

Copy link
Member
fabpot commented Nov 30, 2014

Thank you @rodrigobb.

@fabpot fabpot closed this in 0d32310 Nov 30, 2014
@driskell driskell mentioned this pull request Nov 30, 2014
Merged
fabpot added a commit that referenced this pull request Nov 30, 2014
@fabpot
minor #12786 [Console] [DialogHelper] Fix PHP Fatal error: Cannot cal…
3b7f035 
…l constructor in DialogHelper.php on line 37 (driskell)

This PR was merged into the 2.7 branch.

Discussion
----------

[Console] [DialogHelper] Fix PHP Fatal error: Cannot call constructor in DialogHelper.php on line 37

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | N/A
| License       | MIT
| Doc PR        | N/A

Since yesterday our composer builds have been failing due to an error originating from Symfony/console. We've also been seeing duplicated deprecation warnings:

```
PHP Deprecated:  \Symfony\Component\Console\Helper\DialogHelper is deprecated since version 2.5 and will be removed in 3.0. Use QuestionHelper instead. in vendor/symfony/console/Symfony/Component/Console/Helper/DialogHelper.php on line 14
PHP Deprecated:  DialogHelper is deprecated since version 2.5 and will be removed in 3.0. Use QuestionHelper instead. in vendor/symfony/console/Symfony/Component/Console/Helper/DialogHelper.php on line 35
PHP Fatal error:  Cannot call constructor in vendor/symfony/console/Symfony/Component/Console/Helper/DialogHelper.php on line 37
```

It looks like this was introduced in PR #12737. Then #12759 was raised to change the warning to the header to only print a single warning. But rather than #12759 having #12737 as a parent and reverting it - it's parent is from before #12737 was merged. So there's now a situation of both PR having being merged - one adding deprecation warning to file header, and one adding deprecation to construct() (and also causing fatal error.)

This PR fixes the issue by reverting the breaking parent::construct() added by #12737 so essentially only #12759 is active, which adds a single deprecation warning, and does not break the code.

NB: This is the test failure for the Console component - test fails since #12737. This patch fixes this and passes all tests for the Console component.
```
$ phpunit src/Symfony/Component/Console
PHP Fatal error:  Cannot call constructor in src/Symfony/Component/Console/Helper/DialogHelper.php on line 37
```

Jason

Commits
-------

ada9a58 Fix PHP Fatal error:  Cannot call constructor in symfony/console/Symfony/Component/Console/Helper/DialogHelper.php on line 37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rodrigobb @xabbuh @timglabisch @fabpot
0