[2.1] Extracting translations support. #1259
Conversation
| <parameter key="translation.formatter.php.class">Symfony\Component\Translation\Formatter\PhpFormatter</parameter> | ||
| <parameter key="translation.formatter.pot.class">Symfony\Component\Translation\Formatter\PotFormatter</parameter> | ||
| <parameter key="translation.formatter.xliff.class">Symfony\Component\Translation\Formatter\XliffFormatter</parameter> | ||
| <parameter key="translation.formatter.yml.class">Symfony\Component\Translation\Formatter\YamlFormatter</parameter> |
There was a problem hiding this comment.
Sorry, aptana studio doesn't listen to my indentation settings.
| use Symfony\Component\Console\Input\InputOption; | ||
|
|
||
| class UpdateTransCommand extends Command { | ||
|
|
There was a problem hiding this comment.
The curly braces should be on the next line.
|
This command should go in TwigBundle as it only supports Twig templates. Thus, its design is broken: what about bundle using string translated by another bundle (especially true for app-specific bundles integrating shared bundles) ? In this case, strings may already be translated in another bundle. |
|
I would have liked to pull this request myself as long as I am the owner of theo riginal repository (https://github.com/michelsalib/ExtraToolsBundle). But ok. Also, I do agree with @stof about the bundle thing. But this kind of helper commands cannot satisfy every requirements at first. |
|
@michelsalib: If you are the original author, then you should do the PR yourself. |
|
@ fabpot : thanks. Is it ok if I push it tomorrow ? I'll also take into consideration the comments in this thread. |
|
You have plenty of time as this feature won't be included in 2.0 anyway. It will be considered for 2.1. |
|
@fabpot michesalib said he would do this pull request but did not do it, so that's why I submitted it. @michelsalib I have fixed some things with your code to use the DIC, so you should probably fork xaav/symfony instead of symfony/symfony to include those changes. |
|
I'm closing this, as I will be requesting a pull into michelsalib's fork. |
|
@xaav you are right about the fact I told I would pull it. But you you raised at the time the question of the DIC and I did not have the time to solve it at the moment. So I did not pull the code. BTW thank you for your job about this issue. I planed on using your implementation. Sorry for the inconvenience. |
Now its finished.