8000 remove an unneeded check by xabbuh · Pull Request #12551 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

remove an unneeded check #12551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2014
Merged

remove an unneeded check #12551

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
remove an unneeded check 
It is already checked in the `isEnabled()` method if the current PHP
build is HHVM and the `server:run` command is never enabled then.
Thus, it's not needed to check for HHVM on every command execution.
  • Loading branch information
@xabbuh
xabbuh committed Nov 23, 2014
commit 2035fea2a8d5780241ef6ac70105ce87e43bf184
6 changes: 0 additions & 6 deletions src/Symfony/Bundle/FrameworkBundle/Command/ServerRunCommand.php
View file
Open in desktop
64B8
Original file line number Diff line number Diff line change
Expand Up @@ -83,12 +83,6 @@ protected function configure()
*/
protected function execute(InputInterface $input, OutputInterface $output)
{
if (defined('HHVM_VERSION')) {
$output->writeln('<error>This command is not supported on HHVM.</error>');

return 1;
}

$documentRoot = $input->getOption('docroot');

if (null === $documentRoot) {
Expand Down
0