8000 [EventDispatcher] Add Drupal EventDispatcher by znerol · Pull Request #12521 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[EventDispatcher] Add Drupal EventDispatcher #12521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 18 commits into from
+802 −0
Closed

[EventDispatcher] Add Drupal EventDispatcher #12521

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
ec5e904
Add Drupal EventDispatcher
znerol Nov 19, 2014
84c54d8
Fix namespace, apply patch from CS fixer tool
znerol Nov 20, 2014
eb07cb9
Rename DrupalEventDispatcher to CompiledEventDispatcher
znerol Nov 20, 2014
973b0d3
Use camel-case for variable names, initialize $unsorted on declaratio…
znerol Nov 21, 2014
2548230
Add test covering the EventDispatcherInterface part of CompiledEventD…
znerol Nov 21, 2014
56d8ce5
Add support for tagged listeners to CompiledRegisterListenersPass
znerol Nov 21, 2014
002cf8b
Use camel-case for variable names
znerol Nov 21, 2014
2e39ed6
Add test coverage for CompiledRegisterListenersPass
znerol Nov 21, 2014
a2cd250
Complete test coverage for CompiledEventDispatcher
znerol Nov 21, 2014
60845da
Fix colliding mock subscriber classes
znerol Nov 21, 2014
3a4f177
PHP 5.3 does not support callables in array($object, $method) form
znerol Nov 21, 2014
273a397
Fix coding style
znerol Nov 21, 2014
02d84f7
Fix docs on compiled event dispatcher
znerol Dec 6, 2014
0150640
Use private visibility for instance variables
znerol Dec 8, 2014
d0f986d
Fix codestyle as suggested by @stof
znerol Jan 5, 2015
0bee27f
Use string keys for service definition
znerol Jan 5, 2015
9a9b31c
Replicate #13293
znerol Jan 18, 2015
b4f56ab
Fix code style
znerol Jan 18, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix colliding mock subscriber classes
  • Loading branch information
@znerol
znerol committed Jan 18, 2015
commit 60845da0c60db3fec7e3c2d4b7407990b72855b9
6 changes: 3 additions & 3 deletions ...Component/EventDispatcher/Tests/DependencyInjection/CompiledRegisterListenersPassTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\EventDispatcher\DependencyInjection\CompiledRegisterListenersPass;

class CompiledCompiledRegisterListenersPassTest extends \PHPUnit_Framework_TestCase
class CompiledRegisterListenersPassTest extends \PHPUnit_Framework_TestCase
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason we don't use @coversDefaultClass and @Covers ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use those annotations. You can find some @covers ones but those were added a long time ago.

{
public function testPassAddsConstructorArgument() {
$container = new ContainerBuilder();
Expand All @@ -32,7 +32,7 @@ public function testPassAddsTaggedListenersAndSubscribers() {
$container = new ContainerBuilder();
$definition = $container->register('event_dispatcher', 'stdClass');

$container->register('test_subscriber', 'Symfony\Component\EventDispatcher\Tests\DependencyInjection\SubscriberService')
$container->register('test_subscriber', 'Symfony\Component\EventDispatcher\Tests\DependencyInjection\CompiledSubscriberService')
->addTag('kernel.event_subscriber');

$container->register('test_listener', 'stdObject')
Expand Down Expand Up @@ -138,7 +138,7 @@ public function testAbstractEventListener()
}
}

class SubscriberService implements \Symfony\Component\EventDispatcher\EventSubscriberInterface
class CompiledSubscriberService implements \Symfony\Component\EventDispatcher\EventSubscriberInterface
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should add a use statement

{
public static function getSubscribedEvents()
{
Expand Down
0