Remove aligned '=>' and '=' #12293
Closed
Remove aligned '=>' and '=' #12293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No need to create a PR for 2.5. We first need to merge this one in 2.3, then 2.5. At this point, you will be able to create a PR for 2.5 for additional changes. Thanks. |
|
I checked all files manualy and i think it's good now. Tests are passing on my debian but dunno why they are not passing on Travis. |
|
Thank you @disquedur. |
fabpot
added a commit
that referenced
this pull request
Oct 26, 2014
This PR was squashed before being merged into the 2.3 branch (closes #12293). Discussion ---------- Remove aligned '=>' and '=' | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | [#12284] | License | MIT Could you said to me if i should make an other PR for 2.5 branch. Commits ------- 51312d3 Remove aligned '=>' and '='
This was referenced Oct 27, 2014
fabpot
added a commit
that referenced
this pull request
Oct 31, 2014
This PR was merged into the 2.5 branch. Discussion ---------- [2.5] Remove aligned '=>' and '=' | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | [#12284] | License | MIT PR for 2.3 branch : #12293 Commits ------- e638ccb Remove aligned '=>' and '='
fabpot
added a commit
that referenced
this pull request
Nov 6, 2014
This PR was merged into the 2.6-dev branch. Discussion ---------- Remove aligned '=>' and '=' | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | [#12284] | License | MIT PR for 2.3 branch : #12293 PR for 2.5 branch : #12362 Commits ------- ac1f2b7 Remove aligned '=>' and '='
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could you said to me if i should make an other PR for 2.5 branch.