8000 Add missing argument by wouterj · Pull Request #12208 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

Add missing argument #12208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2014
Merged

Add missing argument #12208

merged 1 commit into from
Oct 13, 2014

Conversation

wouterj
Copy link
Member
@wouterj wouterj commented Oct 10, 2014

->dump has 5 arguments (the 3th argument, the indent, was not provided in the twig extension).

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? let's see
Fixed tickets -
License MIT
Doc PR -

@jakzal
Copy link
Contributor
jakzal commented Oct 11, 2014

👍

1 similar comment
@stof
Copy link
Member
stof commented Oct 13, 2014

👍

@stof
Copy link
Member
stof commented Oct 13, 2014

Thanks for fixing this bug @wouterj.

@stof stof merged commit ac696b8 into symfony:2.3 Oct 13, 2014
stof added a commit that referenced this pull request Oct 13, 2014
This PR was merged into the 2.3 branch.

Discussion
----------

Add missing argument

`->dump` has 5 arguments (the 3th argument, the indent, was not provided in the twig extension).

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | let's see
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

ac696b8 Add missing argument
@wouterj wouterj deleted the patch-8 branch October 13, 2014 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0