[TwigBundle] show correct fallback exception template in debug mode #12196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
Thank you @Tobion. |
fabpot
added a commit
that referenced
this pull request
Oct 10, 2014
…ebug mode (Tobion) This PR was merged into the 2.3 branch. Discussion ---------- [TwigBundle] show correct fallback exception template in debug mode | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - In debug mode, the exception controller did not show the correct template in case the format is unknown. It falls back to html but the logic for `exception_full` was not applied there. So it was just returning the partial html. Commits ------- b97acd9 [TwigBundle] show correct fallback exception template in debug mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In debug mode, the exception controller did not show the correct template in case the format is unknown.
It falls back to html but the logic for
exception_fullwas not applied there. So it was just returning the partial html.