[Router] Cleanup #12183
Closed
[Router] Cleanup #12183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * | ||
| * @return RouteCollection | ||
| */ | ||
| private static function includeFile($file, PhpFileLoader $loader) | ||
| private static function includeFile($file) |
There was a problem hiding this comment.
But this breaks backward compat and removes the possibility to use $loader from the included $file
|
👍 |
| @@ -39,9 +39,7 @@ public static function compile(Route $route) | |||
| { | |||
| $staticPrefix = null; | |||
| $hostVariables = array(); | |||
| $pathVariables = array(); | |||
There was a problem hiding this comment.
Why remove that but $regex for example not?
There was a problem hiding this comment.
It think it is because PhpStorm does not report dead assignments when the assigned value is null, and so he missed it ($staticPrefix as well btw)
fabpot
added a commit
that referenced
this pull request
Oct 13, 2014
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #12183). Discussion ---------- [Router] Cleanup | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Removed unused imports, variables, arguments. Commits ------- 5a6677d [Router] Cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed unused imports, variables, arguments.