8000 [TwigBridge] Replace default list style to icon by Macsch15 · Pull Request #12164 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[TwigBridge] Replace default list style to icon #12164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2014
Merged

[TwigBridge] Replace default list style to icon #12164

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/Symfony/Bridge/Twig/Resources/views/Form/bootstrap_3_layout.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,9 +223,13 @@
{# Errors #}

{% block form_errors -%}
{% if errors|length > 0 %}
{% if errors|length > 0 -%}
{% if form.parent %}<span class="help-block">{% else %}<div class="alert alert-danger">{% endif %}
{{- parent() -}}
<ul class="list-unstyled">
{%- for error in errors -%}
<li><span class="glyphicon glyphicon-exclamation-sign"></span> {{ error.message|trans({}, translation_domain) }}</li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the translation is wrong here. error.message is already translated. See the parent template

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stof I checked it now, after delete trans({}, translation_domain) translations doesn't work.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you mean by "does not work" ? This is how they are displayed in the default theme:

symfony/src/Symfony/Bridge/Twig/Resources/views/Form/form_div_layout.html.twig

Line 292 in d913101

<li>{{ error.message }}</li>

{%- endfor -%}
</ul>
{% if form.parent %}</span>{% else %}</div>{% endif %}
{% endif %}
{%- endif %}
{%- endblock form_errors %}
0