[TwigBridge] fix DumpExtension tests
#12142
Conversation
Make test compatible with the changes from symfony#12125.
|
👍 @symfony/mergers given that volatile tests have been fixed, the Travis status is reliable again, so we need to loose the habit of merging with a red status |
|
@stof We had some broken tests during the last week which made all Travis builds fail. After this pull request, builds for pending PRs should probably be executed again to get more reliable results (there are still two or three volatile tests which fail from time to time). |
|
👍 |
|
Hm, the components tests fail. |
|
looks like SecurityBundle is missing a dependency on Console somewhere |
|
Yes, coming from the test for the |
The `SetAclCommandTest` indirectly requires the Symfony Console component.
|
for some reason, the 2.5.x-dev branch of the form component has been installed rather than using the 2.6-dev version, and the test expectation has been changed in master in #12050 |
|
The version constraint actually is |
|
in the master branch of Symfony ? WTF |
|
I updated it to |
|
Hm, the version constraint was changed in a4217c3 in the |
|
The build finally ran successfully. |
for the same reason: to avoid that the 2.5 branch receives the form expectation of 2.6 😄 |
|
Thanks for the patch. This will need a rebase once #12145 is merged (or the other way around): I renamed Sfjs.dump to Sfdump |
|
Thank you @xabbuh. |
Make test compatible with the changes from #12125.