[Form] Removed constructor argument from FormTypeHttpFoundationExtension for forward compatibility with 2.5 #12033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion for forward compatibility with 2.5
c418d9d to
6cbc862
Compare
|
The issue is that this means that using the HttpFoundationExtension will not read headers from HttpFoundation, but from the superglobals (as you have no way to pass a ServerParams instance initialized with the RequestStack). This is very likely to break tests with the WebTestCase, which don't have the superglobals set (as well as code of people running Symfony in a long-running process through a special setup) |
|
Thank you @webmozart. |
fabpot
added a commit
that referenced
this pull request
Sep 25, 2014
…ndationExtension for forward compatibility with 2.5 (webmozart) This PR was merged into the 2.3 branch. Discussion ---------- [Form] Removed constructor argument from FormTypeHttpFoundationExtension for forward compatibility with 2.5 | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This argument was introduced in #11924. No release was made of the 2.3 branch after merging that PR. Since a different constructor argument (`$requestHandler`) was added to FormTypeHttpFoundationExtension in the 2.5 branch, we cannot merge this forward in a BC fashion. For this reason, I removed the argument again. Commits ------- 6cbc862 [Form] Removed constructor argument from FormTypeHttpFoundationExtension for forward compatibility with 2.5
|
@stof You are right, but that was the same before with FormValidator. We should fix this, but we need to find a proper way to do this. Probably we can only fix this as of 2.5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This argument was introduced in #11924. No release was made of the 2.3 branch after merging that PR.
Since a different constructor argument (
$requestHandler) was added to FormTypeHttpFoundationExtension in the 2.5 branch, we cannot merge this forward in a BC fashion. For this reason, I removed the argument again.