[Form] Renamed the option "empty_value" to "placeholder" #12003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
@webmozart Can you create an issue for the docs? |
|
Thank you @webmozart. |
fabpot
added a commit
that referenced
this pull request
Sep 23, 2014
…r" (webmozart) This PR was merged into the 2.6-dev branch. Discussion ---------- [Form] Renamed the option "empty_value" to "placeholder" | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #5791 | License | MIT | Doc PR | TODO This PR is changing the "empty_value" option to the more understandable name "placeholder". In a subsequent PR, the "placeholder" option should also be added to all types that support the "placeholder" HTML5 attribute. Commits ------- 2b440f3 [Form] Renamed the option "empty_value" to "placeholder"
This was referenced Sep 23, 2014
|
Why doesn't text fields use this option? (it's quite usefull) |
weaverryan
added a commit
to symfony/symfony-docs
that referenced
this pull request
Nov 24, 2014
This PR was merged into the 2.6 branch. Discussion ---------- Renamed empty_value to placeholder | Q | A | --- | --- | Doc fix? | no | New docs? | yes (symfony/symfony#12003) | Applies to | 2.6+ | Fixed tickets | #4261 Commits ------- 54c44ea Renamed empty_value to placeholder
fabpot
added a commit
that referenced
this pull request
Feb 14, 2016
This PR was merged into the 3.0 branch. Discussion ---------- [Form] remove deprecated empty_value_in_choices | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | tiny | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This has been deprecated since 2.6 in #12003. One part has already been removed (`empty_value`) but this part has been forgotten. Commits ------- 735f92e [Form] remove deprecated empty_value_in_choices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is changing the "empty_value" option to the more understandable name "placeholder".
In a subsequent PR, the "placeholder" option should also be added to all types that support the "placeholder" HTML5 attribute.