[Doc] Use Github Markdown syntax highlighting #11999
Conversation
|
From
To :
Just tell me if it will be accepted and I'll do the other files. |
|
👍 |
|
In the past, this kind of changes were rejected. The reason given by Fabien and others was that this is not a standard Markdown syntax. In any case, the recent pseudo-standard published for Markdown supports this syntax: info string on fenced code blocks. If this is something up to vote for the community, I'm strongly in favor of the change 👍 |
|
It's not standard Markdown, but using GitHub to provide the best documentation to developers is nice. |
|
👍 (since this is supported by CommonMark) |
|
Now that there is some new standard adopting this notation, I surrender! Let's update all Mardown files. |
|
Great ! I'll do that later today :) Le 24 sept. 2014 à 08:03, Fabien Potencier notifications@github.com a écrit :
|
|
Have I done a mistake by trying to PR the routing component through symfony/routing#2 ? |
|
@lologhi please submit PRs to symfony/symfony directly (actually, please do the changes in the current PR for all components). Subtree splits repo are read-only |
|
hmm, rather than doing it in the current PR, it might be better to do it in a PR on 2.3, to fix it in this branch, and then update it when needed for newer branches. It will make it easier to merge branches together. |
|
@lologhi Indeed, this should be done in the 2.3 branch. Whenever you are ready, reopen a new PR. Thank you. |
Just on one file, to be sure it will be accepted.