[Form] Changed "allow_html5" to "html5" #11994
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds good to me 👍 |
|
Indeed, much better |
fabpot
added a commit
that referenced
this pull request
Sep 23, 2014
This PR was merged into the 2.6-dev branch. Discussion ---------- [Form] Changed "allow_html5" to "html5" | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This is a follow-up to #8291, which I missed before it was merged. IMO "allow_html5" is a confusing name. We don't "allow" HTML5, but we use it - or we don't. I think "html5" conveys that meaning well and is shorter at the same time. Commits ------- ad171be [Form] Changed "allow_html5" to "html5"
94F4
weaverryan
added a commit
to symfony/symfony-docs
that referenced
this pull request
Nov 24, 2014
This PR was merged into the 2.6 branch. Discussion ---------- Documented html5 option | Q | A | --- | --- | Doc fix? | no | New docs? | yes (symfony/symfony#8291, symfony/symfony#11994) | Applies to | 2.6+ | Fixed tickets | #4262 Commits ------- d08925e Yet another typo fix 238beef Typo fix 22069f4 Documented html5 option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #8291, which I missed before it was merged. IMO "allow_html5" is a confusing name. We don't "allow" HTML5, but we use it - or we don't. I think "html5" conveys that meaning well and is shorter at the same time.