[Form] Add a form error if post_max_size has been reached. #11877
Conversation
| @@ -61,6 +76,10 @@ public function handleRequest(FormInterface $form, $request = null) | |||
| $params = $request->request->get($name, $default); | |||
| $files = $request->files->get($name, $default); | |||
| } else { | |||
| if ($this->serverParams->getContentLength() > $this->serverParams->getPostMaxSize()) { | |||
| $form->addError(new FormError('Max post size exceeded.')); | |||
There was a problem hiding this comment.
Please also add this string in the en translations available in the form component (and for any other language you know of course)
There was a problem hiding this comment.
the form needs to be marked as submitted in this case though, so that the code can know that a submission ended up with errors rather than thinking it is not submitted (and so it is the initial display)
There was a problem hiding this comment.
@stof thank for your feedback, i'm agree with you but i don't know how to tackle this : if i simply set $submitted to true the web profiler don't see the form as submitted but if i submit the form, $errors is cleared.
|
Why are you duplicating the functionality of FormValidator here? |
|
@webmozart the issue is that the FormValidator does not work well. If the post max size is reached (not the upload max size), |
…o request handler (rpg600, webmozart) This PR was merged into the 2.3 branch. Discussion ---------- [Form] Moved POST_MAX_SIZE validation from FormValidator to request handler | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #11729, #11877 | License | MIT | Doc PR | - Commits ------- 759ae1a [Form] Moved POST_MAX_SIZE validation from FormValidator to request handler 4780210 [Form] Add a form error if post_max_size has been reached.
This is my new PR following @lyrixx comments.