[Validator] Fixed time constraint (support formats H, H:i and H:i:s) #11821

bes89 · 2014-09-01T20:36:55Z

This is a reactivated PR, see #9163

Q	A
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	-
License	MIT
Doc PR	-

stof · 2014-09-01T20:42:11Z

@bes89 please rebase your PR as it conflicts with the current state of the master branch

…y, with minutes and with minutes and seconds | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | -

#9163 (comment)

bes89 · 2014-09-01T21:52:00Z

It seems to be good now.
Thank you for your support 👍

Tobion · 2014-09-01T22:53:11Z

src/Symfony/Component/Validator/Exception/InvalidConfigurationException.php

+
+namespace Symfony\Component\Validator\Exception;
+
+class InvalidConfigurationException extends InvalidArgumentException


This class is not needed. There is already a https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Validator/Exception/ConstraintDefinitionException.php

See also https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Validator/Constraints/AbstractComparison.php#L33

stof · 2014-09-02T00:20:26Z

@bes89 when rebasing, you need to force the push to your branch instead of merging the remote branch. Otherwise, it duplicates the commits in the history

webmozart · 2014-09-25T11:48:51Z

I think we should focus our efforts on #11925. Let's keep Date, DateTime and Time as they are.

fabpot mentioned this pull request Sep 1, 2014

[Validator] Fixed time constraint (support formats H, H:i and H:i:s) #9163

Closed

bes89 added 6 commits September 1, 2014 23:10

fixed code see:

ab5388b

#9163 (comment)

added parameter type

ffd618f

allow hour without leading zero

5010a24

used '=== false' instead of '== false'

a76b08e

fixed coding standard and php doc/type issues

dec3ddb

Tobion reviewed Sep 1, 2014
View reviewed changes

fabpot added the Validator label Sep 5, 2014

webmozart mentioned this pull request Sep 15, 2014

[Validator] Replace Date, DateTime and Time by Timestamp #11925

Closed

webmozart closed this Sep 25, 2014

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Validator] Fixed time constraint (support formats H, H:i and H:i:s) #11821

[Validator] Fixed time constraint (support formats H, H:i and H:i:s) #11821


		namespace Symfony\Component\Validator\Exception;

		class InvalidConfigurationException extends InvalidArgumentException

[Validator] Fixed time constraint (support formats H, H:i and H:i:s) #11821

[Validator] Fixed time constraint (support formats H, H:i and H:i:s) #11821

Conversation

Choose a reason for hiding this comment

Choose a reason for hiding this comment