8000 [Debug] fix and enhance exception messages by nicolas-grekas · Pull Request #11759 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Debug] fix and enhance exception messages #11759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 26, 2014
Merged

[Debug] fix and enhance exception messages #11759

merged 1 commit into from
Aug 26, 2014

Conversation

nicolas-grekas
Copy link
Member
Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #11341
License MIT
Doc PR none

@nicolas-grekas nicolas-grekas force-pushed the fix-11341 branch 2 times, most recently from afb4d1b to 9b48164 Compare August 25, 2014 09:31
@fabpot
Copy link
Member
fabpot commented Aug 25, 2014

Can you share some screenshots (before/after) with us?

@nicolas-grekas
Copy link
Member Author

Current master:
capture du 2014-08-25 17 27 32

Enhanced fall-back error page:
capture du 2014-08-25 17 28 22

And for fatal errors that are re-injectable, this was supposed to work but a wrong type hint prevented it:
capture du 2014-08-25 17 28 36

fabpot
fabpot reviewed Aug 25, 2014
View reviewed changes
src/Symfony/Component/HttpKernel/EventListener/DebugHandlersListener.php
@@ -76,7 +74,7 @@ public function configure()
$handler->setExceptionHandler($h);
$handler = is_array($h) ? $h[0] : null;
}
if ($handler instanceof AbstractExceptionHandler) {
if ($handler instanceof ExceptionHandler) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any ways to test this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There must be one :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test added

@nicolas-grekas nicolas-grekas force-pushed the fix-11341 branch 2 times, most recently from 93b789d to 2c19db7 Compare August 25, 2014 18:41
@fabpot
Copy link
Member
fabpot commented Aug 26, 2014

👍

1 similar comment
@romainneutron
Copy link
Contributor

👍

@fabpot
Copy link
Member
fabpot commented Aug 26, 2014

This is only for master?

@nicolas-grekas
Copy link
Member Author

Yep, the feature has been introduced here: 1701447

@fabpot
Copy link
Member
fabpot commented Aug 26, 2014

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 8df1ce8 into symfony:master Aug 26, 2014
fabpot added a commit that referenced this pull request Aug 26, 2014
@fabpot
bug #11759 [Debug] fix and enhance exception messages (nicolas-grekas)
4b507bd 
This PR was merged into the 2.6-dev branch.

Discussion
----------

[Debug] fix and enhance exception messages

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #11341
| License       | MIT
| Doc PR        | none

Commits
-------

8df1ce8 [Debug] fix and enhance exception messages
@nicolas-grekas nicolas-grekas mentioned this pull request Aug 26, 2014
Closed
@nicolas-grekas nicolas-grekas deleted the fix-11341 branch August 26, 2014 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolas-grekas @fabpot @romainneutron
0