8000 [Routing] Add support for 'priority' option for annotated Routes by ghostika · Pull Request #11753 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Routing] Add support for 'priority' option for annotated Routes #11753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

[Routing] Add support for 'priority' option for annotated Routes #11753

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1ddfd1b
Implement priority routes for annotated controller actions
Aug 24, 2014
fe825f3
fix typo and coding standard error
Aug 24, 2014
3804ba9
Put routes with priority in the front
Aug 25, 2014
992e386
add support for routes with negative priority value
Aug 26, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix typo and coding standard error
  • Loading branch information
Andras Ratz committed Aug 24, 2014
commit fe825f3ed17dd53f6a317b5eb0e65b6e958034ac
2 changes: 1 addition & 1 deletion src/Symfony/Component/Routing/Loader/AnnotationClassLoader.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ public function load($class, $type = null)
return $collection;
}

public function adddPriorityRoutes()
public function addPriorityRoutes()
{
krsort($this->routesWithPriority);
$collection = new RouteCollection();
Expand Down
2 changes: 1 addition & 1 deletion src/Symfony/Component/Routing/Loader/AnnotationDirectoryLoader.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ public function load($path, $type = null)
}

if ($this->loader->hasRoutesWithPriority()) {
$collection->addCollection($this->loader->adddPriorityRoutes());
$collection->addCollection($this->loader->addPriorityRoutes());
}

return $collection;
Expand Down
2 changes: 1 addition & 1 deletion src/Symfony/Component/Routing/Loader/AnnotationFileLoader.php
8000
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ public function load($file, $type = null)
}

if ($this->loader->hasRoutesWithPriority()) {
$collection->addCollection($this->loader->adddPriorityRoutes());
$collection->addCollection($this->loader->addPriorityRoutes());
}

return $collection;
Expand Down
1 change: 0 additions & 1 deletion src/Symfony/Component/Routing/Tests/Loader/AnnotationDirectoryLoaderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
use Symfony\Component\Config\FileLocator;
use Symfony\Component\Routing\Annotation\Route;


class AnnotationDirectoryLoaderTest extends AbstractAnnotationLoaderTest
{
protected $loader;
Expand Down
0