[Validator] deprecate member metadata accessors #11703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…property metadata accessors add changelog for deprecations fix test
| @@ -264,10 +266,14 @@ protected function guess($class, $property, \Closure $closure, $defaultValue = n | |||
| $guesses = array(); | |||
| $classMetadata = $this->metadataFactory->getMetadataFor($class); | |||
|
|
|||
| if ($classMetadata->hasMemberMetadatas($property)) { | |||
| $memberMetadatas = $classMetadata->getMemberMetadatas($property); | |||
| if ($classMetadata instanceof ClassMetadataInterface && $classMetadata->hasPropertyMetadata($property)) { | |||
There was a problem hiding this comment.
the metadata for a class should always be a ClassMetadataInterface so I don't think this check is necessary
There was a problem hiding this comment.
It's necessary because the interface only says it returns an MetadataInterface. Everything else is implementation detail we cannot trust.
bd5f345 to
14d3f97
Compare
|
👍 |
1 similar comment
|
👍 |
|
Thank you @Tobion. |
fabpot
added a commit
that referenced
this pull request
Aug 31, 2014
This PR was merged into the 2.6-dev branch. Discussion ---------- [Validator] deprecate member metadata accessors | Q | A | ------------- | --- | Bug fix? | sort of | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | https://github.com/symfony/symfony/pull/11614/files#r16385109 | License | MIT | Doc PR | deprecate member metadata accessors in favor of existing property metadata accessors Commits ------- 14d3f97 [Validator] add getConstraints to MetadataInterface 04eb61b [Validator] deprecate member metadata accessors in favor of existing property metadata accessors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deprecate member metadata accessors in favor of existing property metadata accessors