[Validator] Backported constraint validator tests from 2.5 #11646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
1 similar comment
|
👍 |
|
@webmozart can you rebase please? |
|
After the rebase, are you ok @symfony/deciders to let me merge this PR, then merge 2.3 into 2.4 to allow @webmozart to finish his #11647 PR? |
|
@nicolas-grekas yeah, IMO it is fine (anyway, once it is rebased, @webmozart is allowed to merge the PR as he is merger for the component and 2 other deciders have validated it) |
|
👍 |
webmozart
added a commit
that referenced
this pull request
Aug 14, 2014
….5 (webmozart) This PR was merged into the 2.3 branch. Discussion ---------- [Validator] Backported constraint validator tests from 2.5 | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This PR backports the constraint validator tests from 2.5 to 2.3 to facilitate maintenance. When we adapt a test in 2.3, we can now easily merge the change forward to 2.5. Commits ------- 87a47ea [Validator] Backported constraint validator tests from 2.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR backports the constraint validator tests from 2.5 to 2.3 to facilitate maintenance. When we adapt a test in 2.3, we can now easily merge the change forward to 2.5.