-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Validator] fixed: Expressions always valid for null values #11590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
559 commits
Select commit
Hold shift + click to select a range
64ca6c3
bug #11099 [Debug] work-around https://bugs.php.net/61272 (nicolas-gr…
fabpot e74d37b
Merge branch '2.4' into 2.5
fabpot 4ab34d6
Merge branch '2.5'
fabpot 3d2dd81
[HttpKernel] Fix event dispatcher dependency
hacfi 859f34e
Fixed undefined ImageValidator:: property when uploading an image dur…
OwlyCode 267eaa3
bug #11111 Fixed undefined ImageValidator::$suffices property when up…
fabpot 057c274
bug #11113 [HttpKernel] Fix event dispatcher dependency (hacfi)
fabpot 9e3e89a
feature #8133 [Form] Add allow_extra_fields option on forms (felds)
fabpot aa6b08d
[Validator] Fix array notation in the PropertyPath::append()
jakzal 88a954c
bug #11117 [Validator] Fix array notation in the PropertyPath::append…
fabpot b35250f
[Process] Do not redirect output to file handles when output is disabled
romainneutron 1b253cb
Disallow empty file in FileValidator
megazoll a1762fb
[HttpKernel] added value of DateTime object and objects implementing …
plandolt f4a087b
feature #11125 [Validator] Disallow empty file in FileValidator (mega…
fabpot 1eed20a
feature #11086 [HttpFoundation] Added ParameterBag::getBoolean (peter…
fabpot fd1bfd4
bug #11121 [2.5][Process] Do not redirect output to file handles when…
fabpot 349549c
Merge branch '2.4' into 2.5
fabpot 074c381
Merge branch '2.5'
fabpot 4a93d7f
feature #11070 [HttpKernel] added value of DateTime object to ValueEx…
fabpot 839e9ac
[Debug] generalized ErrorHandler
nicolas-grekas 1701447
[Debug] update FrameworkBundle and HttpKernel for new ErrorHandler
nicolas-grekas d55fe84
feature #10921 [Debug] generic ErrorHandler (nicolas-grekas)
nicolas-grekas 6d9fd62
[FrameworkBundle] Redirect server output to /dev/null in case no verb…
romainneutron 48ed754
[Validator] Support "maxSize" given in KiB
d217c7a
feature #11027 [Validator] Support "maxSize" given in KiB (Jérémy Der…
fabpot d18e758
[Translation] [Xliff] Support for <note>
6587b39
feature #10939 [Translation] [Xliff] Support for <note> (Jérémy Derussé)
fabpot b57024e
[Process] Add support for streams as input
romainneutron 3b4afe7
feature #10934 [Process] Add support for streams as input (romainneut…
fabpot 967576a
[Validator] smaller fixes for binary format
Tobion 2025778
[Validator] no need to initialize properties with null
Tobion 5febbb2
minor #11140 [Validator] smaller CS fixes (Tobion)
fabpot 598d85c
minor #11122 [2.5][FrameworkBundle] Redirect server output to /dev/nu…
fabpot 06cea08
SSI support
kingcrunch 7bb98e2
Update WindowsPipes.php
jgonzalezlopez 71c3a35
bug #11156 Update WindowsPipes.php (jgonzalezlopez)
romainneutron c117e8e
[Console] remove weird use statement
cordoval 02614e0
[Yaml] refactoring of merges for performance
Tobion 9fe4b88
[Console] Fixed notice in QuestionHelper
florianv bebd18c
bug #11170 [Console] Fixed notice in QuestionHelper (florianv)
fabpot 8c621ab
[Yaml] fix priority of sequence merges according to spec
Tobion dee1562
[Yaml] fix overwriting of keys after merged map
Tobion cd0309f
minor #11162 [Console] remove weird use statement (cordoval)
fabpot 83f4ac5
[HttpFoundation] ResponseHeaderBag::clearCookie now accepts secure/ht…
adrienbrault a50aca0
bug #11168 [YAML] fix merge node (<<) (Tobion)
fabpot 76d3c9e
Merge branch '2.4' into 2.5
fabpot d38a4b3
Merge branch '2.5'
fabpot 4450197
Merge branch '2.4' into 2.5
fabpot 9dc55b5
Merge branch '2.5'
fabpot 8308cfa
[Validator] Add en and ru translations for empty file message
megazoll e42c07b
minor #11196 [Validator] Add translation for empty file message (mega…
fabpot 613c86d
[Validator] Added Hungarian translation for empty file
1ed 55934aa
minor #11213 [Validator] Added Hungarian translation for empty file (…
fabpot 0e46e91
[Validator] Added Slovenian translation for empty file
petk 8e1f978
Add missing dot at the end of an exception message
rybakit ff13184
[Validator] added Japanese translation for empty file (id: 78)
issei-m eb5988d
minor #11214 [Validator] Added Slovenian translation for empty file (…
fabpot 8ce7165
minor #11224 [Validator] added Japanese translation for empty file (i…
fabpot fc67000
Added missing dutch translation
wouterj 3111c70
minor #11226 Added missing dutch translation (WouterJ)
fabpot 6f881d4
Added missing Spanish translation
aeoris ce15db5
minor #11228 Added missing Spanish translation (Diego Agulló)
fabpot e712e89
[FrameworkBundle] Simplify "invokable" controllers as services
kbond 579c465
feature #11193 [FrameworkBundle] Simplify "invokable" controllers as …
fabpot 9567b9a
fixed CS
fabpot f5bf45e
[Serializer] Added a test for decoding xml with whitespaces
florianv 8fe71a9
[Validator] Added missing Czech translation
hason c6b751c
minor #11243 [Validator] Added missing Czech translation (hason)
fabpot 7212d0e
[Validator] Polish translation for "empty file" validation
stloyd 279b5e5
minor #11247 [Validator] Polish translation for "empty file" validati…
fabpot a22858b
Merge branch '2.4' into 2.5
fabpot ab3fb14
Merge branch '2.5'
fabpot 1951412
[Translation:update][Xliff Dumper] added target-language.
aitboudad 585a045
Added SK translations
pulzarraider 6a41ca0
minor #11271 [Validator] Added missing Slovak translations (pulzarrai…
fabpot 8b54211
minor #11233 [Serializer] Added a test for decoding xml with whitespa…
fabpot 1fff158
[HttpFoundation] Added a switch to delete file after the response is …
WybrenKoelmans 13c011c
Added line feed to container alias description (text descriptor)
mdouailin 7bc190a
New service to simplify password encoding
aferrandini f9b88c6
Improving the exception message when the bundle name is wrong for the…
weaverryan aae45ad
Make @inheritdoc consistent (lowercase)
hacfi a5f36a8
[Console] Add threshold for ProcessHelper verbosity
romainneutron 6ca1c90
[FrameworkBundle] Use ProcessHelper for server:run command
romainneutron 3779d71
[Debug] Fix tests on PHP 5.6
jakzal 3466601
fix the return types
xabbuh 605a533
minor #11337 [Process] fix the return types (xabbuh)
romainneutron 5feb2b9
minor #11332 [Debug] Fix tests on PHP 5.6 (jakzal)
fabpot 9d6817e
minor #11328 Make @inheritdoc consistent (lowercase) (hacfi)
fabpot 47c686d
Merge branch '2.4' into 2.5
fabpot 782ba96
Merge branch '2.5'
fabpot 7a9d0b3
updated CHANGELOG for 2.5.1
fabpot e3d2844
updated VERSION for 2.5.1
fabpot f56b731
remove the scope from the output of the container:debug command
xabbuh 50a210b
bumped Symfony version to 2.5.2
fabpot d56b7be
[WIP][Form] Improve transformation failure message by providing prope…
jubianchi 71286e1
feature #11318 [WIP][Form] Improve transformation failure message by …
fabpot adb7860
feature #11135 [FrameworkBundle] Use ProcessHelper for server:run com…
fabpot 229828d
feature #11210 [FrameworkBundle] Improving bad bundle exception in _c…
fabpot 17009c1
Merge branch '2.4' into 2.5
fabpot d941f80
Merge branch '2.5'
fabpot 01346f7
feature #11212 [HttpFoundation] Added a switch to delete file after t…
fabpot cd5da9b
[Filesystem] Throw Exception on copying from an unreadable file or to…
djotto e40e325
feature #10960 [Filesystem] Throw Exception on copying from an unread…
fabpot fdc3fb1
[Translation:update][Xliff Dumper] Reviewed code and replaced undersc…
ClementGautier 1ee4a41
feature #11371 [Translation:update][Xliff Dumper] added target-langua…
fabpot 97e07d5
Check for xdebug link format via both ini_get and get_cfg_var
bde043d
[Validator] remove wrong deprecation message
Tobion 8b2397c
Applyied code review
ClementGautier d23320f
feature #11378 Allow xdebug.file_link_format from php ini to work whe…
fabpot 01efafe
minor #11377 [Validator] remove wrong deprecation message (Tobion)
fabpot 9d6b20c
Added support for encoding and decoding namespaced xml (xmlns)
mattvick 5ba40bf
server:run command: provide more error information
xabbuh 2ac1bb4
[Console] Remove estimated field from debug_nomax
bburnichon 7e1b4f6
bug #11284 [Console] Remove estimated field from debug_nomax (bburnic…
stof cd89270
Merge branch '2.4' into 2.5
fabpot 05b2c4e
Merge branch '2.5'
fabpot ff4997f
Merge branch '2.4' into 2.5
fabpot 890cd39
Merge branch '2.5'
fabpot ab765c9
[2.5][Form] solved dependency to ValidatorInterface, fix #11036
a32e819
bug #11350 [2.5][Form] solved dependency to ValidatorInterface, fix #…
fabpot 705d67b
[2.5][Form] solved dependency to ValidatorInterface, fix #11036
f11da64
bug #11350 [2.5][Form] solved dependency to ValidatorInterface, fix #…
fabpot 8805ee1
updated CHANGELOG for 2.5.2
fabpot e66ee96
updated VERSION for 2.5.2
fabpot 28defa8
bumped Symfony version to 2.5.3
fabpot a9af6be
Merge branch '2.4' into 2.5
fabpot 732c9e2
Merge branch '2.5'
fabpot afbaf19
Add compare method to Specificity
barryvdh b8f212d
feature #11404 [CssSelector] Add compare method to Specificity (barry…
fabpot e797659
fixed CS
fabpot 98873b8
Rename Specificity->compare() to compareTo()
barryvdh 397687f
minor #11416 [CssSelector] Rename Specificity->compare() to compareTo…
fabpot 8be4c92
[Console] Fix test on windows
Seldaek ce04073
[Validator] Fixed object initializers in 2.5 version of the Validator
webmozart 4c97420
bug #11410 [Validator] Fixed object initializers in 2.5 version of th…
webmozart d57471e
[Validator] Improve UserPassword message
redstar504 1fdd3df
minor #11383 [Validator] Improve UserPassword message (redstar504)
fabpot cbfcc77
minor #11430 [Console] Fix test on windows (Seldaek)
fabpot ee0a074
feature #11317 remove the scope from the output of the container:debu…
fabpot 6f58674
[FrameworkBundle] changed KernelTestCase::getKernelClass() to check $…
iteman 3f5d4c5
bug #11370 [FrameworkBundle] avoid raising unexpected RuntimeExceptio…
fabpot 283387a
[Validator] Fixed memory leak in ValidatorBuilder
webmozart 2fee576
[DomCrawler] Added node name getter
fejese 2f7b702
bug #11454 [Validator] Fixed memory leak in ValidatorBuilder (webmozart)
fabpot da41eb1
[FrameworkBundle] improved controller name parse error message
jskvara b3b41d5
feature #11314 [FrameworkBundle] Improved controller class error (jsk…
fabpot 91bf277
[Validator] Made sure that context changes don't leak out of (Context…
webmozart a260623
[HttpFoundation] moved test file to the right directory
fabpot fcb7f74
Allow exception bubbling in RememberMeListener
lstrojny d6d462a
[Validator] do not call getter inside ExecutionContext to prevent unn…
Tobion feb4f5c
Merge branch '2.4' into 2.5
fabpot 3b837dc
Merge branch '2.5'
fabpot 5b90572
feature #11173 [HttpFoundation] ResponseHeaderBag::clearCookie now ac…
fabpot d6bbf04
minor #11462 [HttpFoundation] moved test file to the right directory …
fabpot 08529bb
feature #11385 server:run command: provide more error information (xa…
fabpot 96cd78e
feature #11426 [DomCrawler] Added node name getter (fejese)
fabpot c0e4dc6
feature #11375 Added support for encoding and decoding namespaced xml…
fabpot 21e7ad7
fixed CS
fabpot fb9dc6a
feature #10793 [Security] Allow exception bubbling in RememberMeListe…
fabpot bf140a8
feature #10702 [HttpKernel][FrameworkBundle] SSI support (KingCrunch)
fabpot eb48706
feature #11306 [DX] New service to simplify password encoding (aferra…
fabpot 3666c05
minor #11305 [DX] Added line feed to container alias description (tex…
fabpot e4dd60a
minor #11215 [Security] Add missing dot at the end of an exception me…
fabpot 14b60c8
[Validator] Fixed doc block
webmozart ff48939
[Validator] Added markObjectAsInitialized() and isObjectInitialized()…
webmozart a32646e
[SecurityBundle] fix constructor argument index
xabbuh 7af2563
bug #11488 [SecurityBundle] fix constructor argument index (xabbuh)
fabpot e8b53e9
bug #11412 [Validator] Made sure that context changes don't leak out …
webmozart 7e175ef
Merge branch '2.4' into 2.5
fabpot 3e21c4d
Merge branch '2.5'
fabpot 8e461af
[Validator] Constraint validators now use the 2.5 API. For incompatib…
webmozart 7504448
[Validator] Added extensive test coverage for the constraint validato…
webmozart 870a41a
[FrameworkBundle] Made ConstraintValidatorFactory aware of the legacy…
webmozart 3bd6d80
[Validator] CS fixes
webmozart 295e5bb
[Validator] Fixed failing tests
webmozart cd29962
minor #11463 [Validator] prevent unnecessary calls inside ExecutionCo…
webmozart 8744826
Add point about ConsoleLogger to Console 2.5 changelog
JeroenDeDauw 3ee327c
minor #11507 Add point about ConsoleLogger to Console 2.5 changelog (…
fabpot e238637
This files have an invalid namespace
b54a154
minor #11514 This files have an invalid namespace (mmoreram)
fabpot 412f04f
[Validator] German translation for empty file errors
xabbuh 7ee23c1
Replaced ESI mentions with SSI when appropriate
pgodel 88eac04
Issue #11532 Translated 78 in Català
137db21
minor #11528 [Validator] German translation for empty file errors (xa…
fabpot 94ff4e9
minor #11531 [HttpKernel][FrameworkBundle] Replaced ESI mentions with…
fabpot c812379
minor #11534 Issue #11489 Translated 78 in Català (mmoreram)
fabpot 50791c6
[Validator] refs #11489 add some translations in french
vincentaubert 3ecf685
minor #11546 [Validator] refs #11489 add some translations in french …
fabpot 5f06d96
Fixed some extra empty spaces
eiannone ef6f5f5
[Validator] Fixed: Made it possible (again) to pass a class name to V…
webmozart 2bf1b37
[Validator] Fixed ExpressionValidator when the validation root is not…
webmozart c43253e
bug #11498 [Validator] Made it possible (again) to pass a class name …
webmozart a6a7f5d
minor #11485 [Validator] Constraint validators now use the 2.5 API (w…
webmozart 98c0621
Merge branch '2.4' into 2.5
webmozart 27a2280
Merge branch '2.5'
webmozart 6ac130e
[Form] Fixed FormValidator compatibility with the non-BC 2.5 Validati…
webmozart f6c070d
[Validator] Fixed group handling in composite constraints
webmozart 09f252a
feature #11505 [Validator] Fixed group handling in composite constrai…
webmozart acab0a9
minor #11555 [TwigBridge] [Form] Fixed some extra empty spaces (eiann…
fabpot cd322c4
bug #11571 [Form] Fixed FormValidator compatibility with the non-BC 2…
fabpot 6f07919
Merge branch '2.4' into 2.5
fabpot b8f6995
updated CHANGELOG for 2.5.3
fabpot f077a23
updated VERSION for 2.5.3
fabpot 0c13296
bumped Symfony version to 2.5.4
fabpot 0653426
[SecurityBundle] Added UserPasswordValidator tests for the different …
webmozart fba2393
minor #11585 [SecurityBundle] Added UserPasswordValidator tests for t…
webmozart f45f1ab
[DoctrineBridge] Changed UniqueEntityValidator to use the 2.5 Validat…
webmozart e844ed0
[Validator] Removed legacy validator classes
webmozart 9a62ab3
provide a compiler pass for doctrine to register namespace aliases an…
dbu 8bedf86
bug #11582 [DoctrineBridge] Changed UniqueEntityValidator to use the …
webmozart 6b8fe14
minor #11587 [Validator] Removed legacy validator classes (webmozart)
fabpot d2bd92f
[Validator] Added Swedish translations
Nyholm 56f934f
minor #11608 [Validator] Added Swedish translations (78) (Nyholm)
fabpot d3edc2d
feature #10853 provide a compiler pass for doctrine to register names…
fabpot bf7a90e
[Console] fixed output escaping when using the process helper
fabpot 3baea1f
bug #11610 [Console] fixed output escaping when using the process hel…
fabpot 5ca28c0
Merge branch '2.4' into 2.5
fabpot dcce035
add symfony/yaml suggestion to composer.json
xabbuh 19f3b47
resolve parameters before the configs are processed
xabbuh 2cf1205
minor #11623 add symfony/yaml suggestion to composer.json (xabbuh)
fabpot fd0e229
Move debug commands to debug namespace
fe2f007
8000
fix dependencies on HttpFoundation component
xabbuh 7283483
bug #11625 [FrameworkBundle] resolve parameters before the configs ar…
fabpot b8c0a12
[Validator] Fix little typo in ExecutionContextInterface::buildViolat…
1ce0ad5
minor #11656 [Validator] Fix little typo in ExecutionContextInterface…
webmozart 479c833
[FrameworkBundle] Added Crontoller::isCsrfTokenValid
lyrixx 9680c35
minor #11627 [FrameworkBundle] [TwigBundle] Move debug commands to de…
nicolas-grekas 136c5cb
feature #11602 [DX] [FrameworkBundle] Added Crontoller::isCsrfTokenVa…
nicolas-grekas 8c22211
bug #11637 fix dependencies on HttpFoundation component (xabbuh)
nicolas-grekas 7f4f9ab
[DIC] Fixed: anonymous services are always private
lyrixx 35994bf
bug #11666 [DIC] Fixed: anonymous services are always private (lyrixx)
nicolas-grekas 0801a3a
Merge branch '2.4' into 2.5
webmozart 8725243
Merge branch '2.5'
webmozart a74b758
[FrameworkBundle] Fixed validator factory definition when the Validat…
webmozart ff74f4e
[Form] Fixed ValidatorExtension to work with the 2.5 Validation API
webmozart cf8b4e2
bug #11645 [Form] Fixed ValidatorExtension to work with the 2.5 Valid…
webmozart de871dc
Merge branch '2.4' into 2.5
nicolas-grekas 7f38207
Merge branch '2.5'
nicolas-grekas beca900
[HttpFoundation] MongoDbSessionHandler supports auto expiry via confi…
catchamonkey 73c7eae
feature #11668 [HttpFoundation] MongoDbSessionHandler supports auto e…
nicolas-grekas d405f43
[Validator] Fixed Constraint class to not destroy custom groups upon …
webmozart bb9552f
bug #11584 [FrameworkBundle] Fixed validator factory definition when …
webmozart a6beede
bug #11691 [Validator] Fixed Constraint class to not destroy custom g…
webmozart 59cd05f
Merge branch '2.4' into 2.5
webmozart fb97786
[Validator] Fixed missing use statements
webmozart 1d7599d
Merge branch '2.5'
webmozart ce1d209
[Validator] Added ConstraintViolation::getConstraint()
webmozart 2293556
feature #11657 [Validator] Added ConstraintViolation::getConstraint()…
webmozart e13aa6e
[Validator] fixed: Expressions always valid for null values
tommygnr cae9836
Add tests
tommygnr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
8000
Diff view
Diff view
Prev
Previous commit
Add tests
- Loading branch information
commit cae98367a77c2a5cee13f6c9ea044e9232db2529
There are no files selected for viewing
This file contai
6D47
ns hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add tests which explicitly treat the null and empty string scenarios? We need to document that this is an actual feature of the constraint.