8000 [HttpFoundation] MongoDbSessionHandler supports auto expiry via configurable expiry_field by catchamonkey · Pull Request #11510 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[HttpFoundation] MongoDbSessionHandler supports auto expiry via configurable expiry_field #11510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

[HttpFoundation] MongoDbSessionHandler supports auto expiry via configurable expiry_field #11510

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
bb336a5
[HttpFOundation] Added support for auto expiry in MongoSbSessionHandler
catchamonkey Jul 29, 2014
796b18a
Fixes an issue in the mongo handler where the wrong option was used f…
catchamonkey Jul 29, 2014
2d8b2bd
[HttpFoundation] Fixes unit test following the recent update
catchamonkey Jul 29, 2014
4d42f32
Fixes usage of short array syntax to support 5.3
catchamonkey Jul 29, 2014
cb5e562
Use strict comparisons on boolean checks
catchamonkey Jul 29, 2014
d748743
Switched to using yoda expressions
catchamonkey Jul 30, 2014
2f8742e
Return early from the gc method when expiry indexes are used
catchamonkey Aug 1, 2014
fc962db
Modifies the gc tests to use positive values
catchamonkey Aug 1, 2014
b55c63b
Now longer creating the index during write, but have documented it
catchamonkey Aug 4, 2014
88b256c
Corrects error in comment
catchamonkey Aug 4, 2014
9744f61
Removes will and with expectations from method tests that are never c…
catchamonkey Aug 11, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Modifies the gc tests to use positive values
  • Loading branch information
@catchamonkey
catchamonkey committed Aug 1, 2014
commit fc962db8aa906039383caf1ea1fd6683ed147d60
8 changes: 4 additions & 4 deletions ...fony/Component/HttpFoundation/Tests/Session/Storage/Handler/MongoDbSessionHandlerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,10 +198,10 @@ public function testGc()
->method('remove')
->will($this->returnCallback(function ($criteria) use ($that) {
$that->assertInstanceOf('MongoDate', $criteria[$that->options['time_field']]['$lt']);
$that->assertGreaterThanOrEqual(time() - -1, $criteria[$that->options['time_field']]['$lt']->sec);
$that->assertGreaterThanOrEqual(time() - 1, $criteria[$that->options['time_field']]['$lt']->sec);
}));

$this->assertTrue($this->storage->gc(-1));
$this->assertTrue($this->storage->gc(1));
}

public function testGcWhenUsingExpiresField()
Expand Down Expand Up @@ -230,10 +230,10 @@ public function testGcWhenUsingExpiresField()
->method('remove')
->will($this->returnCallback(function ($criteria) use ($that) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will() can be removed, as you expect it will never be called

$that->assertInstanceOf('MongoDate', $criteria[$that->options['time_field']]['$lt']);
$that->assertGreaterThanOrEqual(time() - -1, $criteria[$that->options['time_field']]['$lt']->sec);
$that->assertGreaterThanOrEqual(time() - 1, $criteria[$that->options['time_field']]['$lt']->sec);
}));

$this->assertTrue($this->storage->gc(-1));
$this->assertTrue($this->storage->gc(1));
}

private function createMongoCollectionMock()
Expand Down
0