[WebProfilerBundle][Form] Add information about form synchronization err... #11487
Conversation
|
Epic 👍 sometimes you get a failed transformation because your not using some internal stuff correctly. And its really hard to debug such cases. |
| @@ -134,6 +135,10 @@ public function extractSubmittedData(FormInterface $form) | |||
|
|
|||
| $data['synchronized'] = $this->valueExporter->exportValue($form->isSynchronized()); | |||
|
|
|||
| if ($form instanceof Form && $form->getSynchronizationFailureCause() !== null) { | |||
There was a problem hiding this comment.
Small detail: we are using null !== xxx in Symfony.
|
Looks like a great idea. @webmozart Can you check the implementation? |
|
To make it even more obvious, what about changing the color to red in the toolbar itself (and probably increment the error count to 1 in this case)? |
…error to profiler
|
ok, error count in toolbar and in form panel is incremented by 1 for every transformation failure. |
| } | ||
|
|
||
| /** | ||
| * @return TransformationFailedException |
There was a problem hiding this comment.
TransformationFailedException|null
|
I thought about do that in simillar way as you, but I realized there would be BC-break so I decided to do that in less invasively way. If BC-break is acceptable in that situation, your solution is more elegant and flexible ;) |
When form data transformation fails, the origin error message is lost. This error shouldn't be shown to user, because this is technical error, so maybe a good idea is to show transformation failures in web profiler in
formpanel belowerrorssection?There are no BC-breaks in this PR, I have added public internal method to
Symfony\Component\Form\Formclass, that returnsTransformationFailedException, it is used byFormDataExtractor.Symfony\Component\Form\FormInterfacehas not been touched by me, because that would be a BC-break.