fix some docblocks #11483
Merged
fix some docblocks #11483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
| @@ -321,7 +321,7 @@ public function askHiddenResponse(OutputInterface $output, $question, $fallback | |||
| * @param OutputInterface $output An Output instance | |||
| * @param string|array $question The question to ask | |||
| * @param callable $validator A PHP callback | |||
| * @param int $attempts Max number of times to ask before giving up (false by default, which means infinite) | |||
| * @param int|bool $attempts Max number of times to ask before giving up (false by default, which means infinite) | |||
There was a problem hiding this comment.
true is not valid, so it should be int|false, but I'm not sure it is supported by the phpdoc "spec".
There was a problem hiding this comment.
I thought it isn't. That's the reason I used bool instead.
There was a problem hiding this comment.
We are using xxx|false in quite a few places already, so that's what I would use here as well.
There was a problem hiding this comment.
I see. Changed it here and in the other places as well.
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Aug 2, 2014
This PR was merged into the 2.3 branch. Discussion ---------- fix some docblocks | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- 1775da5 fix some docblocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.