10000 [2.3] [Process] Use correct test for empty string in UnixPipes by romainneutron · Pull Request #11381 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[2.3] [Process] Use correct test for empty string in UnixPipes #11381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 16, 2014
Merged

[2.3] [Process] Use correct test for empty string in UnixPipes #11381

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e1ea4a
[Process] Use correct test for empty string in UnixPipes
whs Jul 1, 2014
cec0a45
[Process] Adjust PR #11264, make it Windows compatible and fix CS
romainneutron Jul 12, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[Process] Adjust PR #11264, make it Windows compatible and fix CS
  • Loading branch information
@romainneutron
romainneutron committed Jul 16, 2014
commit cec0a45ff5951403965d79e085e43538988f2625
11 changes: 9 additions & 2 deletions src/Symfony/Component/Process/Tests/AbstractProcessTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,8 +287,15 @@ public function testGetIncrementalOutput()
}
}

public function testZeroAsOutput(){
$p = $this->getProcess('printf 0');
public function testZeroAsOutput()
{
if (defined('PHP_WINDOWS_VERSION_BUILD')) {
// see http://stackoverflow.com/questions/7105433/windows-batch-echo-without-new-line
$p = $this->getProcess('echo | set /p dummyName=0');
} else {
$p = $this->getProcess('printf 0');
}

$p->run();
$this->assertSame('0', $p->getOutput());
}
Expand Down
0