10000 [Debug] Fix tests on PHP 5.6 by jakzal · Pull Request #11332 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[Debug] Fix tests on PHP 5.6 #11332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2014
Merged

Conversation

jakzal
Copy link
Contributor
@jakzal jakzal commented Jul 6, 2014
Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

On PHP 5.6 debug tests are failing with:

PHP Fatal error:  Class 'Psr\Log\LogLevel' not found in /home/travis/build/symfony/symfony/src/Symfony/Component/Debug/ErrorHandler.php on line 522

I think symfony/debug@4bd5484#diff-b91ca53d6ab50b804cb5783aaf1f9740R71 introduced the problem. Alternative fix would be to initialize the $loggers in a constructor.

ping @nicolas-grekas

@fabpot
Copy link
Member
fabpot commented Jul 7, 2014

👍

1 similar comment
@stof
Copy link
Member
stof commented Jul 7, 2014

👍

@fabpot
Copy link
Member
fabpot commented Jul 7, 2014

Thank you @jakzal.

@fabpot fabpot merged commit 3779d71 into symfony:master Jul 7, 2014
fabpot added a commit that referenced this pull request Jul 7, 2014
This PR was merged into the 2.6-dev branch.

Discussion
----------

[Debug] Fix tests on PHP 5.6

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

On PHP 5.6 [debug tests are failing](https://travis-ci.org/symfony/symfony/jobs/29118115#L357) with:

```
PHP Fatal error:  Class 'Psr\Log\LogLevel' not found in /home/travis/build/symfony/symfony/src/Symfony/Component/Debug/ErrorHandler.php on line 522
```

I think symfony/debug@4bd5484#diff-b91ca53d6ab50b804cb5783aaf1f9740R71 introduced the problem. Alternative fix would be to initialize the `$loggers` in a constructor.

ping @nicolas-grekas

Commits
-------

3779d71 [Debug] Fix tests on PHP 5.6
@jakzal jakzal deleted the debug-tests-in-5.6-fix branch July 7, 2014 09:43
@nicolas-grekas
Copy link
Member

Thanks for the fix

@nicolas-grekas
Copy link
Member

This looks like a new bug in the area: https://bugs.php.net/67436 (not exactly https://bugs.php.net/42098)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0