8000 remove the scope from the output of the container:debug command by xabbuh · Pull Request #11317 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@xabbuh
Copy link
Member
@xabbuh xabbuh commented Jul 5, 2014
Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #11302
License MIT
Doc PR

@javiereguiluz
Copy link
Member

I've checked the Symfony documentation and there are no listings for the output of the container:debug command, so it's not necessary a doc PR to complement this PR.

@xabbuh
Copy link
Member Author
xabbuh commented Jul 5, 2014

@javiereguiluz Thanks for checking the docs.

@stof
Copy link
Member
stof commented Jul 8, 2014

👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not removed the scope from non-text formats (YAML, XML, ...) as they mostly consumed by tools that might need this information.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point.

What do you think about the output of a single service? Would you like to keep the scope there too as @stof suggested?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that makes sense.

@xabbuh
Copy link
Member Author
xabbuh commented Jul 8, 2014

I updated the pull request to remove the scope information only in the list of services when the text format is used.

@fabpot
Copy link
Member
fabpot commented Jul 23, 2014

👍

Sorry, something went wrong.

@fabpot
Copy link
Member
fabpot commented Jul 23, 2014

Thank you @xabbuh.

@fabpot fabpot merged commit f56b731 into symfony:master Jul 23, 2014
fabpot added a commit that referenced this pull request Jul 23, 2014
…g command (xabbuh)

This PR was merged into the 2.6-dev branch.

Discussion
----------

remove the scope from the output of the container:debug command

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #11302
| License       | MIT
| Doc PR        |

Commits
-------

f56b731 remove the scope from the output of the container:debug command
@xabbuh xabbuh deleted the issue-11302 branch July 24, 2014 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

0