8000 Remove Spaceless Blocks From Twig Templates by chrisguitarguy · Pull Request #11278 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Remove Spaceless Blocks From Twig Templates #11278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

Remove Spaceless Blocks From Twig Templates #11278

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ed0a0e9
Remove Spaceless Block From Textarea Widgets
chrisguitarguy Jul 3, 2014
43cc810
Add Test Cases to Expose Whitespace Only Textarea Value Bug
chrisguitarguy Jul 3, 2014
88db345
Remove Spaceless Blocks from Higher-Up Form Blocks
chrisguitarguy Jul 3, 2014
1ac162a
Remove @group Annotation from Tests
chrisguitarguy Jul 3, 2014
fca6cb8
Remove Spaceless in Favor of Whitespace Control
chrisguitarguy Jul 3, 2014
de4a268
Only Assert That Attribute is Not Present
chrisguitarguy Jul 3, 2014
0a81522
Pull False Widget Attribute Test Up in AbstractLayoutTest
chrisguitarguy Jul 3, 2014
33812de
Remove spaceless blocks from attributes
chrisguitarguy Jul 3, 2014
547489c
Remove the Final Spaceless Blocks
chrisguitarguy Jul 9, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Only Assert That Attribute is Not Present 
No need to match against the whole string: only confirm that `false`
attributes are not present.
  • Loading branch information
@chrisguitarguy
chrisguitarguy committed Jul 3, 2014
commit de4a268afd9919c4568db0963a745934087119ad
6 A688 changes: 2 additions & 4 deletions src/Symfony/Component/Form/Tests/AbstractLayoutTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1929,8 +1929,7 @@ public function testWidgetAttributeHiddenIfFalse()

$html = $this->renderWidget($form->createView());

// no foo
$this->assertSame('<input type="text" id="text" name="text" required="required" value="value" />', $html);
$this->assertNotContains('foo="', $html);
}

public function testButtonAttributes()
Expand Down Expand Up @@ -1966,8 +1965,7 @@ public function testButtonAttributeHiddenIfFalse()

$html = $this->renderWidget($form->createView());

// no foo
$this->assertSame('<button type="button" id="button" name="button">[trans]Button[/trans]</button>', $html);
$this->assertNotContains('foo="', $html);
}

public function testTextareaWithWhitespaceOnlyContentRetainsValue()
Expand Down
0