-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[Process] Fix ExecutableFinder with open basedir #11179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to< 8000 /strong>
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
Add test for open_basedir use in ExecutableFinder
- Loading branch information
commit 8a79dce0b22156b6104c28f693c14d9d979c8c1b
There are no files selected for viewing
42 changes: 42 additions & 0 deletions
42
src/Symfony/Component/Process/Tests/ExecutableFinderTest.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
<?php | ||
|
||
/* | ||
* This file is part of the Symfony package. | ||
* | ||
* (c) Fabien Potencier <fabien@symfony.com> | ||
* | ||
* For the full copyright and license information, please view the LICENSE | ||
* file that was distributed with this source code. | ||
*/ | ||
|
||
namespace Symfony\Component\Process\Tests; | ||
|
||
use Symfony\Component\Process\ExecutableFinder; | ||
|
||
/** | ||
* @author Chris Smith <chris@cs278.org> | ||
*/ | ||
class ExecutableFinderTest extends \PHPUnit_Framework_TestCase | ||
{ | ||
public function testFindWithOpenBaseDir() | ||
{ | ||
if (!defined('PHP_BINARY')) { | ||
$this->markTestSkipped('Requires the PHP_BINARY constant'); | ||
} | ||
|
||
if (defined('PHP_WINDOWS_VERSION_BUILD')) { | ||
$this->markTestSkipped('Cannot run test on windows'); | ||
} | ||
|
||
if (ini_get('open_basedir')) { | ||
$this->markTestSkipped('Cannot test when open_basedir is set'); | ||
} | ||
|
||
ini_set('open_basedir', dirname(PHP_BINARY).PATH_SEPARATOR.'/'); | ||
|
||
$finder = new ExecutableFinder; | ||
$result = $finder->find(basename(PHP_BINARY)); | ||
|
||
$this->assertEquals(PHP_BINARY, $result); | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be restored to default value IMO, this is how it's done in every other test touching ini settings etc..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not possible to remove
open_basedir
restrictions at runtime, hence I permit/
.