8000 [Console] Fixed notice in DialogHelper by florianv · Pull Request #11169 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[Console] Fixed notice in DialogHelper #11169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2014
Merged

Conversation

florianv
Copy link
Contributor
Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
License MIT

When pressing escape in a question, a notice is shown because the sequence is only 2 characters long.

@stof
Copy link
Member
stof commented Jun 18, 2014

👍

1 similar comment
@romainneutron
Copy link
Contributor

👍

@fabpot
Copy link
Member
fabpot commented Jun 19, 2014

Thank you @florianv.

@fabpot fabpot merged commit ff6c65e into symfony:2.3 Jun 19, 2014
fabpot added a commit that referenced this pull request Jun 19, 2014