[WIP] [TwigBundle] [Exception] Make return value similar to error.json.twig #11078
Conversation
|
Running tests just for this bundle depends on #11077 |
|
I have no clues why both Travis and fabbot.io failed. |
|
@clemens-tolboom is not your fault on travis-ci, about fabbot.io no idea |
|
👍 |
|
ping @symfony/deciders |
|
I guess due to the different structure anyone relying on the structure probably just created code that would be able to deal with both structures .. at the very least it should be an easy fix to either remove the now no longer needed version or to overwrite this template. so +1 |
|
👍 however: should we add a note in the CHANGELOG.md or UPGRADE.md files ? |
|
I think the changelog is enough (this does not affect the prod environment, only the debug ones) |
|
👍 |
|
@clemens-tolboom Can you add a note in the CHANGELOG file of the bundle? |
3903d81 to
8674e5a
Compare
| @@ -1,6 +1,11 @@ | |||
| CHANGELOG | |||
| ========= | |||
|
|
|||
| 2.4.0 | |||
There was a problem hiding this comment.
It's going to be in 2.6 and this is a BC break, so you should prefix the line with [BC BREAK] (as such, I would also change fixed by changed.)
|
Thank you @clemens-tolboom. |
…ar to error.json.twig (clemens-tolboom) This PR was squashed before being merged into the 2.6-dev branch (closes #11078). Discussion ---------- [WIP] [TwigBundle] [Exception] Make return value similar to error.json.twig | Q | A | ------------- | --- | Bug fix? | I guess this is a bug | New feature? | The exception structure changes for the default | BC breaks? | The exception structure changes for the default | Deprecations? | [yes|no] | Tests pass? | [yes|no] | Fixed tickets | | License | MIT | Doc PR | The result for `error.json.twig` and `exception.json.twig` differ making the client forced to check for it's result. We think the structure should be the same to make the ie a javascript client try to respond similar for --env=dev|prod Commits ------- 4a59f98 [WIP] [TwigBundle] [Exception] Make return value similar to error.json.twig
The result for
error.json.twigandexception.json.twigdiffer making the client forced to check for it's result.We think the structure should be the same to make the ie a javascript client try to respond similar for --env=dev|prod