8000 [DependencyInjection] Fix #10626, use better check on attribute existence and values on XML load by romainneutron · Pull Request #10629 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[DependencyInjection] Fix #10626, use better check on attribute existence and values on XML load #10629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 3, 2014
Merged

[DependencyInjection] Fix #10626, use better check on attribute existence and values on XML load #10629

merged 1 commit into from
Apr 3, 2014

Conversation

romainneutron
Copy link
Contributor
Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #10626
License MIT

@stof
Copy link
Member
stof commented Apr 3, 2014

👍

inelgnu
inelgnu reviewed Apr 3, 2014
View reviewed changes
src/Symfony/Component/DependencyInjection/Tests/Fixtures/xml/services14.xml
<argument /><!-- Channel -->
</service>
</services>
</container>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing new line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed

@lmammino
Copy link
lmammino commented Apr 3, 2014

👍 Waiting for this fix to be merged

@francoispluchino
Copy link
Contributor

👍

@jmeyo
Copy link
jmeyo commented Apr 3, 2014

Joining the long queue for that critical fix to be merged, but still 👍

fabpot added a commit that referenced this pull request Apr 3, 2014
@fabpot
bug #10629 [DependencyInjection] Fix #10626, use better check on attr…
bc6020d 
…ibute existence and values on XML load (romainneutron)

This PR was merged into the 2.5-dev branch.

Discussion
----------

[DependencyInjection] Fix #10626, use better check on attribute existence and values on XML load

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #10626
| License       | MIT

Commits
-------

8163427 [DependencyInjection] Fix #10626, use better check on attribute existence and values on XML load
@fabpot fabpot merged commit 8163427 into symfony:master Apr 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@romainneutron @stof @lmammino @francoispluchino @jmeyo @inelgnu @fabpot
0