[Validator][Email] - When standalone "Fatal error: Class 'validator.email' not found" #10581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests failure is due to See here |
|
Thank you @egulias. |
fabpot
added a commit
that referenced
this pull request
Mar 30, 2014
…validator.email' not found" (egulias) This PR was merged into the 2.5-dev branch. Discussion ---------- [Validator][Email] - When standalone "Fatal error: Class 'validator.email' not found" | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | silexphp/Silex#932 | License | MIT | Doc PR | no When using the validator as an standalone component a bug was introduced by overriding the `validatedBy()` method in the `Email` constraint. This PR removes the override and implements a way for the DI to get the right validator. Another way would be modifying the definition of validator to change the alias instead of having the FQCN in the xml Commits ------- e79b3a9 Change in validator.email service alias to match the validator FQCN
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the validator as an standalone component a bug was introduced by overriding the
validatedBy()method in theEmailconstraint.This PR removes the override and implements a way for the DI to get the right validator.
Another way would be modifying the definition of validator to change the alias instead of having the FQCN in the xml