[Bug][DataCollector] Fix the regression caused by the removal of double-stringification #10361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -52,6 +52,9 @@ public function collect(Request $request, Response $response, \Exception $except | |||
| foreach ($request->attributes->all() as $key => $value) { | |||
| if ('_route' === $key && is_object($value)) { | |||
| $value = $value->getPath(); | |||
|
|
|||
There was a problem hiding this comment.
remove line break, also would be a good idea to add a regression test
There was a problem hiding this comment.
Line break before elseif is not in convention of code?
There was a problem hiding this comment.
@francoispluchino it is not.
There was a problem hiding this comment.
👍 for adding a regression test
There was a problem hiding this comment.
👍 I do this.
|
That's not enough. Actually, we need to serialize everything here (fixed in #10367). |
fabpot
added a commit
that referenced
this pull request
Mar 3, 2014
…ctor (fabpot) This PR was merged into the 2.5-dev branch. Discussion ---------- [HttpKernel] fixed serialization of the request data collector | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #10361 | License | MIT | Doc PR | n/a This fixes a regression introduced in #10352. Commits ------- 6102f99 [HttpKernel] fixed serialization of the request data collector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the commit dce66c9, an exception is thrown when an Object is part of the list of request parameters.
For example, the ParamFetcher object of the FosRestBundle included the Request object, and this object, included the Session object. The serialization fails when we use the PDO handler session.