[Form][Twig] Add an additional input html5 attribute if with_secondes parameters in setted #10203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| License | MIT |
|
Oups, i saw a big mistake, i have to change the with_minutes by with_seconds ! |
|
What's the status of this PR? |
|
Fixed, you can merge |
|
Can you also fix the PHP template and add some unit tests? |
| @@ -148,6 +148,9 @@ | |||
| {% block time_widget %} | |||
| {% spaceless %} | |||
| {% if widget == 'single_text' %} | |||
| {% if with_seconds %} | |||
| {% set attr = attr|merge({'step': 1 }) %} | |||
There was a problem hiding this comment.
You should merge the attributes the other way round, so people can override it.
Also have you considered
The following control allows any time in the day to be selected, with any accuracy (e.g. thousandth-of-a-second accuracy or more):
<input name=favtime type=time step=any>
|
Closing in favor of #10777 |
fabpot
added a commit
that referenced
this pull request
May 16, 2014
…ets to display seconds if needed (tucksaun) This PR was squashed before being merged into the 2.3 branch (closes #10777). Discussion ---------- [Form] Automatically add step attribute to HTML5 time widgets to display seconds if needed | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #9976, #10203 | License | MIT | Doc PR | none Same issue as #9976 and #10203: when you add a `time` field to a form with options `single_text` (so HTML5) and `with_seconds`, the generated input does not contain the `step` attribute, therefore the browser does not show them, leading to an error at the submit because of an invalid format. Compared to #9976/#10203: * Unit testable * Available directly in the component * Available in other templating format than twig * Still able to customise the step attribute by hand Commits ------- a379298 [Form] Automatically add step attribute to HTML5 time widgets to display seconds if needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.